Skip to content

Change document.querySelectorAll(query)[0] to querySelectorquery #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Change document.querySelectorAll(query)[0] to querySelectorquery #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
acc3172
Change document.querySelectorAll(query)[0] to document.querySelectorq…
kh3dr0n Oct 14, 2018
b5cbda4
Merge branch 'master' into update-queryselector-dom-api
gavinmccormack Oct 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions client/clientDisplay.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,15 @@ export class clientDisplay {
//Methods from this class are called from clientGame.js upon game-state changes.
constructor(gameState) {
//These DOM calls are temporary, as we will be switching to data-targets!
this.gameMessage = document.querySelectorAll('*[data-game-message]')[0]; // These indexes mean there's no flexibility for now, as we need to wrap
this.secretWord = document.querySelectorAll('*[data-secret-word-container]')[0]; // Used by the code to calculate, may as well be a variable.
this.testt = document.querySelectorAll('[data-secret-word-display]')[0]; // Visible to user
this.userGuesses = document.querySelectorAll('*[data-user-guesses]')[0];
this.onlinePlayers = document.querySelectorAll('*[data-online-players]')[0];
this.guessInput = document.querySelectorAll('*[data-guess-input]')[0];
this.usernameInput = document.querySelectorAll('*[data-username-input]')[0];
this.guessSubmit = document.querySelectorAll('*[data-guess-submit]')[0];
this.usernameSubmit = document.querySelectorAll('*[data-username-submit]')[0];
this.gameMessage = document.querySelector('*[data-game-message]'); // These indexes mean there's no flexibility for now, as we need to wrap
this.secretWord = document.querySelector('*[data-secret-word-container]'); // Used by the code to calculate, may as well be a variable.
this.testt = document.querySelector('[data-secret-word-display]'); // Visible to user
this.userGuesses = document.querySelector('*[data-user-guesses]');
this.onlinePlayers = document.querySelector('*[data-online-players]');
this.guessInput = document.querySelector('*[data-guess-input]');
this.usernameInput = document.querySelector('*[data-username-input]');
this.guessSubmit = document.querySelector('*[data-guess-submit]');
this.usernameSubmit = document.querySelector('*[data-username-submit]');
this.bodyParts = ['Head',
'Torso',
'Right_Arm',
Expand Down
1 change: 0 additions & 1 deletion client/clientSocket.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ var socket = io('http://localhost:5000');
var clientGame = require('./clientGame.js').clientGame;
var game = null;


export function setUsername(username) {
socket.emit('setUsername', username);
}
Expand Down