Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved GPU usage withing the required #ifdefs #13

Open
wants to merge 2 commits into
base: pastix_push2
Choose a base branch
from

Conversation

boris-martin
Copy link

When disabling CUDA, a few compilations arise. After investigation, it seems a few lines where placed outside of the macros checking whether or not CUDA is used. I fixed heuristically (fixing until it compiled) and haven't tested thoroughly the impacts of the change.

@Kabbone
Copy link
Contributor

Kabbone commented Oct 25, 2021

These changes shouldn't be enough. There are some arguments which need to be changed. Most necessary changes you can find in my branch cudaless, but this would need some rework to make it flexible during compile time.
Kabbone/PaStiX4CalculiX@pastix_push2...Kabbone:cudaless

@boris-martin
Copy link
Author

These changes shouldn't be enough. There are some arguments which need to be changed. Most necessary changes you can find in my branch cudaless, but this would need some rework to make it flexible during compile time. Kabbone/PaStiX4CalculiX@pastix_push2...Kabbone:cudaless

Indeed, I realized afterwards that my changes allowed the code to compile with CUDA disabled but installed, but on machines where it was not installed, it is still not enough. (mostly because of CUBLAS)
Thanks for pointing your branch, this has gone way above my skill level

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants