Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LIMS-979: Add Unqueue All and Unqueue Selected buttons to Container Queue page #665

Merged
merged 4 commits into from
Jan 19, 2024
Merged

LIMS-979: Add Unqueue All and Unqueue Selected buttons to Container Queue page #665

merged 4 commits into from
Jan 19, 2024

Conversation

ndg63276
Copy link
Collaborator

Ticket: LIMS-979

Changes:

  • Use get rather than post on queue/unqueue all as no data being sent in
  • Add buttons for Unqueue All and Unqueue Selected
  • Add functions to unqueue all or just selected
  • Rearrange divs and spans to use unused screen space
  • Display 'loading' spinner while functions run

Tests:

  • Test Queue All still works with get
  • Tick some samples and click Unqueue Selected, test they disappear from queue, refresh page to ensure they are still unqueued
  • Click Unqueue All, test the queue is empty, refresh page to ensure queue is still empty
  • Test no errors appear if no samples are queued or no samples are selected

gfrn
gfrn previously requested changes Jan 18, 2024
View reviewed changes
client/src/js/modules/imaging/views/queuecontainer.js Show resolved Hide resolved
api/src/Page/Sample.php Outdated Show resolved Hide resolved
client/src/js/modules/imaging/views/queuecontainer.js Outdated Show resolved Hide resolved
client/src/js/modules/imaging/views/queuecontainer.js Outdated Show resolved Hide resolved
client/src/js/modules/imaging/views/queuecontainer.js Outdated Show resolved Hide resolved
client/src/js/modules/imaging/views/queuecontainer.js Outdated Show resolved Hide resolved
client/src/js/modules/imaging/views/queuecontainer.js Outdated Show resolved Hide resolved
ndg63276 and others added 2 commits January 18, 2024 10:26
@ndg63276 @gfrn
Use let instead of var
da3e06b 
Co-authored-by: Guilherme Francisco <guilherme.de-freitas@diamond.ac.uk>
LIMS-979: Use post requests for queueing/unqueueing
395de3d
@ndg63276 ndg63276 requested a review from gfrn January 19, 2024 11:29
@ndg63276 ndg63276 dismissed gfrn’s stale review January 19, 2024 11:30

Should be fixed

@ndg63276 ndg63276 merged commit 30a3164 into prerelease Jan 19, 2024
2 checks passed
@ndg63276 ndg63276 deleted the improvement/LIMS-979/add-unqueue-all/selected-buttons branch January 19, 2024 17:07
gfrn added a commit that referenced this pull request Feb 26, 2024
@ndg63276 @gfrn
LIMS-979: Add Unqueue All and Unqueue Selected buttons to Container Q…
63f64e5 
…ueue page (#665)

* LIMS-979: Add Unqueue All and Unqueue Selected buttons to Container Queue page

* Use let instead of var

Co-authored-by: Guilherme Francisco <guilherme.de-freitas@diamond.ac.uk>

* LIMS-979: Use post requests for queueing/unqueueing

---------

Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>
Co-authored-by: Guilherme Francisco <guilherme.de-freitas@diamond.ac.uk>
gfrn added a commit that referenced this pull request Mar 5, 2024
@ndg63276 @gfrn
LIMS-979: Add Unqueue All and Unqueue Selected buttons to Container Q…
dff753e 
…ueue page (#665)

* LIMS-979: Add Unqueue All and Unqueue Selected buttons to Container Queue page

* Use let instead of var

Co-authored-by: Guilherme Francisco <guilherme.de-freitas@diamond.ac.uk>

* LIMS-979: Use post requests for queueing/unqueueing

---------

Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>
Co-authored-by: Guilherme Francisco <guilherme.de-freitas@diamond.ac.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfrn gfrn gfrn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndg63276 @gfrn