Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIMS-1018: Cannot clone samples in new puck #668

Closed

Conversation

ndg63276
Copy link
Collaborator

JIRA ticket: LIMS-1018

Summary:

Ticket LIMS-759 (multipins) introduced a bug whereby the "clone sample" button didn't work.

Changes:

  • Revert 1 change from LIMS-759: Show multipin samples and their sublocations #648
  • The locationIndex is used only when pressing the "Add Container" button, and that index is used to splice a new sample into the existing samples. Using the INDEX property meant numbers larger than the capacity of the container were used.

To test:

  • Test creating a puck with different samples, view puck to check samples have been saved
  • Test creating a puck with cloned samples (ie after using the "Clone sample" button), view puck to check samples have been saved
  • Test creating a puck after using the "Clone all from first row" button, view puck to check samples have been saved
  • Test existing containers without sublocations still look ok eg /containers/cid/245858
  • Test samples in sublocations are shown on existing containers eg /containers/cid/270597
  • Test editing samples individually and with the bulk editor

@ndg63276
Copy link
Collaborator Author

Changes for LIMS-759 have been reverted.

@ndg63276 ndg63276 closed this Sep 20, 2023
@ndg63276 ndg63276 deleted the fix/LIMS-1018/cannot-clone-samples-in-new-puck branch June 24, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant