Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fake PathProvider to startup module #783

Merged
merged 5 commits into from
Feb 3, 2025
Merged

Conversation

callumforrester
Copy link
Contributor

@callumforrester callumforrester commented Jan 16, 2025

This is a workaround (not a fix) for #784, so won't close it. The replacement of PathProvider in dodal will eventually provide the proper fix. For now I think we should just pretend to write to a directory with our start-up file, despite the fact that none of the simulated detectors actually write files.

@callumforrester callumforrester changed the title Failing system tests for plans Add fake PathProvider to startup module Feb 3, 2025
@callumforrester callumforrester marked this pull request as ready for review February 3, 2025 14:15
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.46%. Comparing base (b605942) to head (3b3a228).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #783   +/-   ##
=======================================
  Coverage   93.46%   93.46%           
=======================================
  Files          38       38           
  Lines        2111     2111           
=======================================
  Hits         1973     1973           
  Misses        138      138           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@callumforrester callumforrester merged commit ffa0913 into main Feb 3, 2025
31 checks passed
@callumforrester callumforrester deleted the plan-system-tests branch February 3, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants