Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable polling of config parameters and update in a separate loop #18

Merged
merged 4 commits into from
Dec 12, 2023
Merged

Disable polling of config parameters and update in a separate loop #18

merged 4 commits into from
Dec 12, 2023

Conversation

GDYendell
Copy link
Contributor

@GDYendell GDYendell commented Nov 28, 2023 •
edited
Loading

Some tweaks to the FastCS core could make this a bit neater, but it works for now.

@GDYendell GDYendell requested a review from TBThomas56 November 28, 2023 16:17
@codecov Codecov
Copy link

codecov bot commented Nov 28, 2023 •
edited
Loading

Codecov Report

Attention: 38 lines in your changes are missing coverage. Please review.

Comparison is base (a5b2021) 41.33% compared to head (7d0fbd9) 39.56%.
Report is 2 commits behind head on main.

Files Patch % Lines
src/eiger_fastcs/eiger_controller.py 35.41% 31 Missing ⚠️
src/eiger_fastcs/__main__.py 30.00% 7 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
- Coverage   41.33%   39.56%   -1.78%     
==========================================
  Files           3        3              
  Lines         150      182      +32     
==========================================
+ Hits           62       72      +10     
- Misses         88      110      +22

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GDYendell GDYendell force-pushed the config-fetch branch 4 times, most recently from ab39bfd to 5aef7d2 Compare November 29, 2023 10:58
@GDYendell
Copy link
Contributor Author

I need to remind myself if there is a good reason that the current logic is complicated and if we should just clear the set and let it fill up again while fetching. I think if the same parameter is added again, we can't be sure if we updated before or after, so we should just update it again.

TBThomas56
TBThomas56 reviewed Dec 6, 2023
View reviewed changes
Copy link
Collaborator

@TBThomas56 TBThomas56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gary - "Is a good reason that the current logic is complicated and if we should just clear the set and let it fill up again while fetching. I think if the same parameter is added again, we can't be sure if we updated before or after, so we should just update it again."

@GDYendell
Disable config polling
1daa258 
Make config parameters only update once on startup
Update put to handle response and trigger the returned parameters
to be updated.
Add update loop to request specific parameters that need updating
@GDYendell
Tidying
23cb986 
Remove name from LogicHandler
Explicitly define ntrigger to use in code
Use Attribute.get() instead of Attribute._value
Remove TODO - No sleep is required
@GDYendell
Add ignored parameters
199ba73 
These should not be included in the PV interface or polled
@GDYendell
Only create controller once
7d0fbd9
@GDYendell GDYendell merged commit 855154a into main Dec 12, 2023
13 of 16 checks passed
@GDYendell GDYendell deleted the config-fetch branch December 12, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TBThomas56 TBThomas56 TBThomas56 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GDYendell @TBThomas56