Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i04 Development #40

Merged
merged 7 commits into from
Jul 31, 2024
Merged

i04 Development #40

merged 7 commits into from
Jul 31, 2024

Conversation

GDYendell
Copy link
Contributor

No description provided.

Fix commands by removing value when not expected to avoid 404 status.

Remove automatic triggering logic, remove ntrigger as internal
parameter.

Update trigger to put with value if in inte mode with trigger_exposure
set or without value otherwise.
Update to fastcs 0.5.0 for Attribute allowed_values
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 51.42857% with 17 lines in your changes missing coverage. Please review.

Project coverage is 71.16%. Comparing base (c7b6ff1) to head (ad08127).

Files Patch % Lines
src/eiger_fastcs/eiger_controller.py 46.87% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
- Coverage   71.95%   71.16%   -0.79%     
==========================================
  Files           4        4              
  Lines         271      274       +3     
==========================================
  Hits          195      195              
- Misses         76       79       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This was copied from the tickit-devices system tests
@GDYendell GDYendell merged commit a15718e into main Jul 31, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant