-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more structure to controllers #51
Conversation
Rename EigerHandler name to uri
843895d
to
88c8065
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #51 +/- ##
==========================================
+ Coverage 68.82% 72.20% +3.38%
==========================================
Files 4 4
Lines 263 295 +32
==========================================
+ Hits 181 213 +32
Misses 82 82 ☔ View full report in Codecov by Sentry. |
1744560
to
b9384f3
Compare
Opening as tickit-devices changes have been merged and I've rewritten the tests to pass with the new structure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have had a first look over and it looks like a good start, but I don't think the overall structure is quite right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks much better now! Second pass review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine to ignore the codecov patch failure here as the project coverage is higher with this.
Thanks @jsouter! Are you happy to merge?
Yep, think it's in a good state! |
Setting as a draft as I have not fixed the tests yet, and I may refactor to make it less convoluted.
Fixes #49