Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for EigerHandler and EigerConfigHandler #53

Merged
merged 8 commits into from
Dec 3, 2024

Conversation

jsouter
Copy link
Collaborator

@jsouter jsouter commented Nov 15, 2024

Closes (#45)

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.06%. Comparing base (3e1482b) to head (3571281).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #53       +/-   ##
===========================================
+ Coverage   72.20%   84.06%   +11.86%     
===========================================
  Files           4        4               
  Lines         295      295               
===========================================
+ Hits          213      248       +35     
+ Misses         82       47       -35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@GDYendell GDYendell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments.

I think it might be a good idea to intentionally strip down the mock connection here to what we actually use. Or maybe just a MagicMock with specific responses in each test. We do have the system tests for running the introspection against the tickit sim to test the full api.

tests/test_controller.py Outdated Show resolved Hide resolved
tests/test_controller.py Outdated Show resolved Hide resolved
tests/test_controller.py Outdated Show resolved Hide resolved
tests/test_controller.py Outdated Show resolved Hide resolved
tests/test_controller.py Outdated Show resolved Hide resolved
@jsouter jsouter linked an issue Nov 21, 2024 that may be closed by this pull request
tests/test_controller.py Outdated Show resolved Hide resolved
@jsouter jsouter force-pushed the update-handlers-tests branch 2 times, most recently from 9ce3c4d to 6f17078 Compare November 28, 2024 15:22
Copy link
Contributor

@GDYendell GDYendell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new unit tests look good 👍

@jsouter jsouter force-pushed the update-handlers-tests branch from b9aef0c to 3571281 Compare December 2, 2024 11:46
@jsouter jsouter requested a review from GDYendell December 2, 2024 11:48
@GDYendell GDYendell merged commit 3bdfc71 into main Dec 3, 2024
19 checks passed
@GDYendell GDYendell deleted the update-handlers-tests branch December 3, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests for update task / handlers and stale parameters logic
2 participants