-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for EigerHandler and EigerConfigHandler #53
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
===========================================
+ Coverage 72.20% 84.06% +11.86%
===========================================
Files 4 4
Lines 295 295
===========================================
+ Hits 213 248 +35
+ Misses 82 47 -35 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments.
I think it might be a good idea to intentionally strip down the mock connection here to what we actually use. Or maybe just a MagicMock with specific responses in each test. We do have the system tests for running the introspection against the tickit sim to test the full api.
9ce3c4d
to
6f17078
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new unit tests look good 👍
b9aef0c
to
3571281
Compare
Closes (#45)