Roll back bluesky version #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #882 +/- ##
=======================================
Coverage 87.57% 87.57%
=======================================
Files 105 105
Lines 7106 7106
=======================================
Hits 6223 6223
Misses 883 883
|
olliesilvester
approved these changes
Mar 3, 2025
| @@ -18,7 +18,6 @@ dependencies = [ | |||
| # | |||
| "annotated_types", | |||
| "caproto", | |||
| "confluent-kafka==2.8.0", | |||
There was a problem hiding this comment.
Maybe we should leave this pin in? Unless the latest confluent-kafka is working now
There was a problem hiding this comment.
I think that the confluent-kafka is a dependency of bluesky and bluesky==1.13.0 has it pinned at confluent-kafka==2.8.0 so we should be fine
DominicOram
added a commit
that referenced
this pull request
Mar 3, 2025
This reverts commit 1cefe70.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #881
Link to dodal PR (if required): DiamondLightSource/dodal#1083
Instructions to reviewer on how to test:
Checks for reviewer