Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I23 can go to lower energies (longer wavelengths) than the other MX beamlines, so measuring around lower energy absorption edges is possible. Consequently, I23 are interested in being able to fit lower energy edges in MCA spectra. Previously, these lower energy edges would get included in the fit by having these lower energy edges defined in the peaks section of the I23 config file at
/dls_sw/i23/software/pymca/pymca_new.cfgand the normal list of MX edges would be appended by the pymca_fitter service.In recent changes, this functionality was lost and instead, if peaks were defined in the config file, the fitter would only use those peaks and would not append more. Having peaks hard-coded into the config file has a weakness as the batch fitting function from the PyMCA module will not work if an edge that is higher than the photon energy is included. Therefore, instead of having the peaks in the config file, this change adds a list of I23 elements that will be appended to the config file, so long as the edges sufficiently lower than the beam energy.
This change will require the peaks in
/dls_sw/i23/software/pymca/pymca_new.cfgto be removed to take effect.