Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github actions #1118

Merged
merged 4 commits into from
Jun 19, 2024
Merged

Add github actions #1118

merged 4 commits into from
Jun 19, 2024

Conversation

getzze
Copy link
Collaborator

@getzze getzze commented Jun 7, 2024

I wrote 2 files:

  • one for lint and type checking
  • one for the test and coverage. Tests are failing right now.

@getzze
Copy link
Collaborator Author

getzze commented Jun 7, 2024

@DerouineauNicolas can you also review this PR please?
@Diaoul didn't add you as maintainer yet so I cannot assign you automatically :(

@DerouineauNicolas
Copy link
Contributor

Looks good to me ! Good job !

@getzze
Copy link
Collaborator Author

getzze commented Jun 8, 2024 via email

@DerouineauNicolas
Copy link
Contributor

DerouineauNicolas commented Jun 10, 2024

I'm not sure this is a good idea to call the external APIs in the CI. I would leaves the cassettes to catch any requests, but maybe I didn't understand the problematic correctly.

@getzze
Copy link
Collaborator Author

getzze commented Jun 12, 2024

My idea was to run automatic test every month, with empty cassettes, so we make sure that the API are still working.
After a PR or push maybe we don't need to call the API and we could used cached cassettes.
But anyway I want the tests for the different OS and python-version to use cached cassettes also.

So maybe writing another test to run every month on a single OS-python-version and with empty cassettes would be OK.

@getzze
Copy link
Collaborator Author

getzze commented Jun 13, 2024

For python versions <= 3.9, it seems that the cassettes with a gzipped content cannot be decompressed.
Any idea how to force a non-compression, so we can re-run the faulty cassettes?

@getzze
Copy link
Collaborator Author

getzze commented Jun 13, 2024

for python-version 3.10, the tests pass after applying #1127

for python-version 3.12, we need to solve #1126 first.

@DerouineauNicolas
Copy link
Contributor

From my perspective, the simpliest way to disable gzip compression would be to regenerate the cassetes with the option decode_compressed_response=True (https://vcrpy.readthedocs.io/en/latest/advanced.html#decode-compressed-response)

@getzze
Copy link
Collaborator Author

getzze commented Jun 15, 2024 via email

@getzze
Copy link
Collaborator Author

getzze commented Jun 18, 2024

all the tests are passing except for one in version py312 which is affected by #1126 .

@getzze getzze merged commit 67f17cc into Diaoul:develop Jun 19, 2024
17 of 20 checks passed
@getzze getzze deleted the add-gh-actions branch July 6, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants