Add Subtitulamos provider integration #1170
Conversation
|
Thanks for updating this provider! Don't worry too much about mypy (or if you need help let me know). It's better if coverage is high ;) |
…3.8 compatibility
| # modify spanish latino subtitle language to only spanish and set hearing_impaired = True | ||
| # because if exists spanish and spanish latino subtitle for the same episode, the score will be | ||
| # higher with spanish subtitle. Spanish subtitle takes priority. | ||
| if language == Language('spa', 'MX'): | ||
| language = Language('spa') | ||
| hearing_impaired = True |
There was a problem hiding this comment.
this is a hack that will stop working with changes to come to how hearing_impaired and foreign_only/forced subtitles are sorted. See #1175 for the first step.
Why do you need to transform a american-spanish subtitle to a european-spanish subtitle? It can be specified by having both languages (or only one) in the command line, no?
There was a problem hiding this comment.
I'm not really sure, I thought the same when I saw that on the original proposal, but I decided to keep it in case there was something I missed. Let me perform some test and make the commit removing the block.
Added Subtitulamos provider
This PR is partially based and replaces #826 (skipping the provider "tusubtitulo" as is not working anymore)
Also I added a way to run the cli from source code (subliminal/cli.py#L727-L728) , as is helpful to debug new additions (if you don't like it, tell me and I'll remove it)Pending: