Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pfft gradients #34

Merged
merged 3 commits into from
Dec 22, 2024
Merged

Fix pfft gradients #34

merged 3 commits into from
Dec 22, 2024

Conversation

ASKabalan
Copy link
Collaborator

Updating jaxDecomp version and adding tests to ensure that we can get decent gradients

@ASKabalan
Copy link
Collaborator Author

ASKabalan commented Dec 21, 2024

@EiffL

Fell free to bump version and make release if it is urgent
I think that even with jaxdecomp v0.2.2 as dependency the pip installer will select v0.2.3 since the constraint is >=0.2.2

Anyways if tests pass this can be merged

note: BackSolveAdjoint tests are skipped. they won't work because I need to implement JVP custom rules in jaxDecomp instead of VJP (will be done soon)

note2: I think that there is a small modification to do in jaxDecomp to enable BackSolveAdjoint

@ASKabalan ASKabalan requested a review from EiffL December 21, 2024 23:14
Copy link
Member

@EiffL EiffL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Wassim!

@EiffL EiffL merged commit cb2a7ab into main Dec 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants