Add .net 10 as a target framework #1170
Conversation
There was a problem hiding this comment.
Pull request overview
This PR attempts to add .NET 10 as a target framework for the SoapCore library and its related projects. However, there is a critical issue: .NET 10 does not exist yet as of December 2025. The latest version of .NET is .NET 9, which was released in November 2024. Microsoft follows an annual release cadence, so .NET 10 would not be expected until November 2025 at the earliest.
Key Changes
- Added
net10.0as a target framework across multiple project files (SoapCore, tests, benchmarks) - Updated package references to use version 10.x packages that do not exist
- Created new .NET 10 sample projects (Net10Server and Net10Client)
- Updated Visual Studio solution file to reference non-existent Visual Studio 18
Reviewed changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| src/SoapCore/SoapCore.csproj | Adds net10.0 target framework and references non-existent v10 packages |
| src/SoapCore.Tests/SoapCore.Tests.csproj | Adds net10.0 target with non-existent v10 test packages |
| src/SoapCore.Benchmark/SoapCore.Benchmark.csproj | Adds net10.0 target for benchmarks with invalid package versions |
| samples/Sample.sln | Updated to reference non-existent Visual Studio 18 and includes new .NET 10 projects |
| samples/README.md | Documentation referencing non-existent .NET 10 |
| samples/Net10Server/* | New sample server project targeting non-existent net10.0 framework |
| samples/Net10Client/* | New sample client project targeting non-existent net10.0 framework |
| samples/Net10Sample/README.md | Documentation for non-existent .NET 10 sample |
| .gitignore | Added lutconfig file to ignore list |
Critical Issue: All references to .NET 10 (net10.0) and version 10.x packages should be changed to .NET 9 (net9.0) and appropriate version 9.x packages to target the actual latest .NET version.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
You say that .net 10 does not exists. But it really does it was released november 2025.
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 41 out of 43 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 41 out of 43 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 41 out of 43 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 41 out of 43 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1 participant
I added .net 10, upgraded nugets, removed deprecated aspnetcore3.1 (supported partly by netstandard) and fixed warnings from stylecop.