-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filtering improvements #182
base: master
Are you sure you want to change the base?
Conversation
Recommendation: Show the "All Labels" as unchecked or in the ambiguous state if any of the labels are unchecked. I think. it is more likely you want to go back to showing all labels than showing no labels. |
I'm having trouble getting the filter by comparison section to do what I expect. I want to show where predictions differ from labels (or labels differ from predictions). I can't seem to pick labels on the left. When I pick predictions and differs from, picking labels on the right seems to go back to saying any. I'm not sure what is happening: filterby.mp4 |
028d720
to
49fcd10
Compare
Updated!
This has been fixed now. |
Either there is still an issue or I am confused about what is supposed to be happening. See video. The left side of filter by only lets me pick predictions (not labels). Filter by Labels by me gets different results than filtering by labels (even though I'm the only who has labeled something); and picking labels on the right then shows "Any". filterby.mp4 |
- Fix comparison operator to ensure we're comparing user ids - Do not disable the "any" option for second comparison choice - Fix clashing component ids
- Adds the option to group by prediction or by review. - Removes the "agree/disagree" grouping option as it's too ambiguous
- Add the options to sort by predictions or reviews - Remove the option to sort by agree/disagree because of ambiguity
Add "All Labels" option to the labels filter menu. Checking the "All Labels" option selects all labels. Unchecking removes all label filters. Labels can still be checked/unchecked individually. The "no label" filter remains its own option.
This adds "All Reviews" to the reviews filter menu to mirror the setup of the labels filter menu.
For the comparison filters make sure that we confirm that the first option and operator have been set before trying to update any filtering.
- Improve naming for added clarity - Add clarifying comments - Update metadata on queued superpixels to ensure none are missed
Only disable an option if it is the exact same option as the one already selected. Disable the second selection until the first selection and operator are chosen.
49fcd10
to
412427e
Compare
groupBy
optionsagree/disagree
grouping option as it's too ambiguoussortBy
optionsagree/disagree
because of ambiguityreviews
filter menu to better match thelabels
filter menu. This adds "All Reviews" to the reviews filter menu to mirror the setup of the labels filter menu.