Skip to content

Add D3D_FEATURE_LEVEL_12_2 #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 27, 2024
Merged

Conversation

2A5F
Copy link
Contributor

@2A5F 2A5F commented Nov 23, 2024

No description provided.

@TheMostDiligent
Copy link
Contributor

TheMostDiligent commented Nov 23, 2024

Hello!

This change currently fails to build with the older Windows SDK version:

C:\projects\DiligentCore\Graphics\GraphicsEngineD3DBase\include\EngineFactoryD3DBase.hpp(298,29): error C2065: 'D3D_FEATURE_LEVEL_12_2': undeclared identifier (compiling source file C:\projects\DiligentCore\Graphics\GraphicsEngineD3D12\src\EngineFactoryD3D12.cpp) [C:\projects\DiligentCore\build\Graphics\GraphicsEngineD3D12\Diligent-GraphicsEngineD3D12-static.vcxproj]

It is necessary to find out in which SDK version this enum value was first defined and add a fallback value for older SDK versions.

@2A5F
Copy link
Contributor Author

2A5F commented Nov 24, 2024

Should use directx heades instead of windows sdk to avoid this situation

@TheMostDiligent
Copy link
Contributor

Should use directx heades instead of windows sdk to avoid this situation

This will require quite a bit of work, which is not justified by this specific change.
For this PR to work, adding a fallback value is much simpler.

Copy link
Contributor

@TheMostDiligent TheMostDiligent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like required changes are missing here, here, and here

@2A5F 2A5F requested a review from TheMostDiligent November 25, 2024 17:27
@2A5F 2A5F requested a review from TheMostDiligent November 26, 2024 13:56
@2A5F 2A5F requested a review from TheMostDiligent November 27, 2024 11:46
@TheMostDiligent TheMostDiligent merged commit 4540839 into DiligentGraphics:master Nov 27, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants