Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

53 - PROTOTYPE scope support #56

Merged
merged 3 commits into from
Feb 20, 2025
Merged

53 - PROTOTYPE scope support #56

merged 3 commits into from
Feb 20, 2025

Conversation

SergiiKravchuk
Copy link
Collaborator

Changes:

  • added support of prototype-scoped beans for DefaultBeanFactory;
  • expanded BeanDefinition interface; adjusted DefaultBeanFactory#createBean to create only prototype-scoped beans;
  • added BeanDefinitionFactory to avoid using BeanDefinition implementations in the DefaultBeanFactory;
  • simplified and refactored AutowiredAnnotationBeanPostProcessorTests and InitDestroyAnnotationBeanPostProcessorTest;
  • [QoL] added suppressions for simple warnings.

@SergiiKravchuk
Copy link
Collaborator Author

Temporary targeting https://github.com/DimaGalchenko/winter-framework/tree/47-autowiring-constructor branch for easier changes review.

@SergiiKravchuk SergiiKravchuk self-assigned this Feb 9, 2025
@SergiiKravchuk SergiiKravchuk force-pushed the 47-autowiring-constructor branch 3 times, most recently from 0e4d6f4 to 1a49282 Compare February 9, 2025 16:25
@SergiiKravchuk SergiiKravchuk force-pushed the 53-prototype-scope-support branch from 9273ce8 to cbdfd39 Compare February 16, 2025 11:35
@SergiiKravchuk SergiiKravchuk force-pushed the 47-autowiring-constructor branch from 1a49282 to f500208 Compare February 16, 2025 11:46
@SergiiKravchuk SergiiKravchuk force-pushed the 53-prototype-scope-support branch from cbdfd39 to ff8b960 Compare February 16, 2025 11:52
53 - added support of prototype-scoped beans for DefaultBeanFactory; …
3e2ac71 
…expanded BeanDefinition interface; adjusted DefaultBeanFactory#createBean to create only prototype-scoped beans; added BeanDefinitionFactory to avoid using BeanDefinition implementations in the DefaultBeanFactory; simplified and refactored AutowiredAnnotationBeanPostProcessorTests and InitDestroyAnnotationBeanPostProcessorTest; added suppressions for simple warnings
@SergiiKravchuk SergiiKravchuk force-pushed the 53-prototype-scope-support branch from ff8b960 to 3e2ac71 Compare February 16, 2025 11:56
@SergiiKravchuk SergiiKravchuk changed the base branch from 47-autowiring-constructor to develop February 16, 2025 11:57
DimaGalchenko
DimaGalchenko approved these changes Feb 16, 2025
View reviewed changes
Copy link
Owner

@DimaGalchenko DimaGalchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor:

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@DimaGalchenko DimaGalchenko merged commit efff52e into develop Feb 20, 2025
3 checks passed
@DimaGalchenko DimaGalchenko deleted the 53-prototype-scope-support branch February 20, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndriyPavlyuk AndriyPavlyuk AndriyPavlyuk approved these changes

@khshanovskyi khshanovskyi khshanovskyi approved these changes

@DimaGalchenko DimaGalchenko DimaGalchenko approved these changes

@jekafortuna jekafortuna Awaiting requested review from jekafortuna

@Mitos35 Mitos35 Awaiting requested review from Mitos35

@ShpakDmytro ShpakDmytro Awaiting requested review from ShpakDmytro

Assignees

@SergiiKravchuk SergiiKravchuk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SergiiKravchuk @AndriyPavlyuk @khshanovskyi @DimaGalchenko