Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

49 implement a bean definition scanner #58

Merged
merged 10 commits into from
Feb 21, 2025
Merged

49 implement a bean definition scanner #58

merged 10 commits into from
Feb 21, 2025
+296 −251

Conversation

AndriyPavlyuk
Copy link
Collaborator

No description provided.

@AndriyPavlyuk
Implement bean definition scanner
1ea9e53
@AndriyPavlyuk
Merge branch 'develop' into 49-implement-a-beandefinitionparserbeande…
26fae10 
…finitionfactory

# Conflicts:
#	src/main/java/com/codeus/winter/context/AnnotationApplicationContext.java
@AndriyPavlyuk AndriyPavlyuk linked an issue Feb 3, 2025 that may be closed by this pull request
Implement a BeanDefinitionParser(BeanDefinitionFactory) #49
Closed
DimaGalchenko
DimaGalchenko approved these changes Feb 6, 2025
View reviewed changes
Copy link
Owner

@DimaGalchenko DimaGalchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SergiiKravchuk
SergiiKravchuk reviewed Feb 9, 2025
View reviewed changes
@AndriyPavlyuk
Refactor code; Remove redundant class. Add unit test.
4d28865
@AndriyPavlyuk
Merge branch 'develop' into 49-implement-a-beandefinitionparserbeande…
167b61b 
…finitionfactory

# Conflicts:
#	src/test/java/com/codeus/winter/config/PackageBeanRegistrationTest.java
@AndriyPavlyuk
Add unit test
8c692e3
@AndriyPavlyuk
Refactor tests, create additional package for testing classes
c6c2ab9
@AndriyPavlyuk
Merge branch 'develop' into 49-implement-a-beandefinitionparserbeande…
e5677ea 
…finitionfactory

# Conflicts:
#	src/main/java/com/codeus/winter/context/AnnotationApplicationContext.java
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
83.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@DimaGalchenko DimaGalchenko merged commit a270261 into develop Feb 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergiiKravchuk SergiiKravchuk SergiiKravchuk approved these changes

@khshanovskyi khshanovskyi khshanovskyi approved these changes

@DimaGalchenko DimaGalchenko DimaGalchenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement a BeanDefinitionParser(BeanDefinitionFactory)
4 participants
@AndriyPavlyuk @SergiiKravchuk @khshanovskyi @DimaGalchenko