Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8a84aadee9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .onKeyEvent { | ||
| when (it.key) { | ||
| androidx.compose.ui.input.key.Key.DirectionRight -> { |
There was a problem hiding this comment.
This handler pages on every left/right key event without checking KeyEventType, which conflicts with FlareHardwareShortcutsNode.onKeyEvent() in FlareHardwareShortcutDetector.kt that only consumes KeyDown and returns false for KeyUp. In practice, when a zoomed image handles arrow-key panning on key-down, the key-up event still bubbles here and triggers animateScrollToPage(...), so a pan gesture can also switch to the next/previous media item. Restricting this logic to key-down (or consuming matching key-up events) avoids unintended page changes while panning.
Useful? React with 👍 / 👎.
1 participant
No description provided.