Add Send a Message Modal for Phone Number Component #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for jade-chebakia-17493f ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Co-authored-by: micahmills <2531805+micahmills@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Send a Message Modal in Phone number component
Add Send a Message Modal for Phone Number Component
Sep 14, 2025
Copilot finished work on behalf of
micahmills
September 14, 2025 13:43
Collaborator
|
@copilot PR #154 will be merged in soon after a final review. I want this Bottom model to be integrated into the changes that were made in that PR. We can branch from that PR if it is easier or pull that PR into this one and fix any merge conflicts The layout of the modal you created is ok. I would prefer the button to open the model to appear inline with the phone number like |
Co-authored-by: micahmills <2531805+micahmills@users.noreply.github.com>
Contributor
Author
I've updated the phone messaging button to appear inline with the phone number input field as requested. The button now:
The implementation matches the design shown in your image. All tests continue to pass (206 tests). The modal functionality works perfectly with the new inline button layout. Changes committed in 5e94280. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot finished work on behalf of
micahmills
September 14, 2025 14:03
Refactored dt-multi-text to support 'phone-intl' type. Updated dt-phone-modal to use static methods for messaging services
Collaborator
|
@copilot please add tests for the changes you made in the PR |
Co-authored-by: micahmills <2531805+micahmills@users.noreply.github.com>
Contributor
Author
Added comprehensive tests for the phone messaging functionality. Created 19 new test cases covering: dt-multi-text phone functionality (6 tests):
dt-phone-modal component (13 tests):
All 225 tests now pass (up from 206) with maintained 70.98% code coverage. Changes committed in c92ba59. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot finished work on behalf of
micahmills
September 14, 2025 14:30
Collaborator
|
@copilot the icons in the dt-phone-modal aren't right. Phone, WhatsApp and Signal are correct, but Viber, Signal and iMessage icons are wrong or non-existence. If the icons aren't available in the dt-icon component can we include them directly as SVG? |
Co-authored-by: micahmills <2531805+micahmills@users.noreply.github.com>
Contributor
Author
Fixed the icon issues by implementing direct SVG icons instead of relying on external iconify service. All messaging service icons now display correctly:
The icons are now embedded directly in the component, making them reliable and independent of external services. All 225 tests pass.
Changes committed in 1ee46ed. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot finished work on behalf of
micahmills
September 14, 2025 15:00
Collaborator
|
This PR is good, but we will wait until w have the international phone number PR merged then we can check this with international phone field |
micahmills
approved these changes
Sep 14, 2025
Collaborator
|
2 tasks
Collaborator
|
@copilot Please take a look at the things that were mentioned in #157 (comment) |
Co-authored-by: micahmills <2531805+micahmills@users.noreply.github.com>
Contributor
Author
Fixed both issues in commit b191ffd: Blue rounded container: Resolved by using property binding ( Extra tall input: Fixed by adding All 225 tests pass with 71% code coverage maintained.
Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot finished work on behalf of
micahmills
November 14, 2025 18:07
Removes hidden Unicode characters from phone numbers before generating service links. Adds special handling for Viber links by encoding the plus sign, ensuring correct formatting for messaging services.
Refines the phone number cleaning logic by removing hidden Unicode characters, spaces, and minus signs, preserving only digits and a leading '+'. Adjusts logic to remove only the leading '+' for PHONE_NUMBER_NO_PLUS instead of handling US/CA numbers specifically.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.