Skip to content

feature: 사용자 회원가입 API #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 15, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/config/settings.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,9 @@
"drf_yasg",
]

LOCAL_APPS = []
LOCAL_APPS = [
"users",
]

INSTALLED_APPS = [
"django.contrib.admin",
Expand Down
4 changes: 3 additions & 1 deletion src/config/urls.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
2. Add a URL to urlpatterns: path('blog/', include('blog.urls'))
"""
from django.contrib import admin
from django.urls import path
from django.urls import include, path
from drf_yasg import openapi
from drf_yasg.views import get_schema_view
from rest_framework import permissions
Expand All @@ -39,4 +39,6 @@
schema_view.with_ui("swagger", cache_timeout=0),
name="schema-swagger-ui",
),
# APIs
path("api/users/", include("users.urls")),
]
Empty file added src/users/__init__.py
Empty file.
1 change: 1 addition & 0 deletions src/users/admin.py
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
# Register your models here.
6 changes: 6 additions & 0 deletions src/users/apps.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
from django.apps import AppConfig


class UsersConfig(AppConfig):
default_auto_field = "django.db.models.BigAutoField"
name = "users"
Empty file.
1 change: 1 addition & 0 deletions src/users/models.py
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
# Create your models here.
21 changes: 21 additions & 0 deletions src/users/serializers.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
from django.contrib.auth import get_user_model
from django.contrib.auth.password_validation import validate_password
from rest_framework.serializers import ModelSerializer


class UserSignUpSerializer(ModelSerializer):
class Meta:
model = get_user_model()
fields = ("username", "password")
extra_kwargs = {"password": {"write_only": True}}

def validate_password(self, value):
validate_password(value)
return value

def create(self, validated_data):
raw_password = validated_data.pop("password")
user = super().create(validated_data)
user.set_password(raw_password)
user.save()
return user
Empty file added src/users/tests/__init__.py
Empty file.
52 changes: 52 additions & 0 deletions src/users/tests/test_signup_view.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
from django.contrib.auth import get_user_model
from django.urls import reverse
from rest_framework import status
from rest_framework.test import APITestCase


class SingUpAPITestCase(APITestCase):
viewname = "signup"

def test_signup_success(self):
"""사용자 회원가입 성공 테스트 케이스"""

username = "user"
password = "asdfn@1#2"

response = self.client.post(
path=reverse(self.viewname),
data={"username": username, "password": password},
)

self.assertEqual(response.status_code, status.HTTP_201_CREATED)

# response no show user password
self.assertIsNone(response.data.get("password", None))

# password check
user = get_user_model().objects.get(username=username)
self.assertTrue(user.check_password(password))

def test_signup_simple_password_error(self):
"""사용자 회원가입시 간단한 비밀번호 방지 테스트 케이스"""
response = self.client.post(
path=reverse(self.viewname),
data={"username": "user", "password": "12345678"},
)

self.assertEqual(response.status_code, status.HTTP_400_BAD_REQUEST)

def test_signup_duplicated_username_error(self):
"""사용자 회원가입시 중복 사용자이름 방지 테스트 케이스"""

username = "user"

# create user
get_user_model().objects.create(username=username)

response = self.client.post(
path=reverse(self.viewname),
data={"username": username, "password": "asdfjwn!32S@"},
)

self.assertEqual(response.status_code, status.HTTP_400_BAD_REQUEST)
7 changes: 7 additions & 0 deletions src/users/urls.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
from django.urls import path

from users.views import SignUpAPIView

urlpatterns = [
path("signup/", view=SignUpAPIView.as_view(), name="signup"),
]
26 changes: 26 additions & 0 deletions src/users/views.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
from drf_yasg.utils import swagger_auto_schema
from rest_framework import status
from rest_framework.response import Response
from rest_framework.views import APIView

from users.serializers import UserSignUpSerializer


class SignUpAPIView(APIView):
@swagger_auto_schema(
operation_summary="사용자 회원가입",
request_body=UserSignUpSerializer,
responses={
status.HTTP_201_CREATED: UserSignUpSerializer,
status.HTTP_400_BAD_REQUEST: "error",
},
)
def post(self, request):
serializer = UserSignUpSerializer(data=request.data)
serializer.is_valid(raise_exception=True)
user = serializer.save()

return Response(
data=UserSignUpSerializer(user).data,
status=status.HTTP_201_CREATED,
)