-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
프로젝트 root 분리 #25
Merged
Merged
프로젝트 root 분리 #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 개발 환경 구성을 위한 project root와 repository root 분리 - repository root : git, docker, readme 등 환경 및 개발 구성 파일 포함 - project root(src) : 장고 project 포함
- repository root와 project root가 분리 되면서 Docker 환경 세팅 - Dockerfile에서 /app/src/에 project를 프로젝트를 마운트하여 사용 - /app/pyproject.toml은 Poetry venv 활성화하기 위한 조건
- flake8의 max-line-length, exclue에 대한 setup.cfg 파일 copy 적용
해당 프로젝트 구조가 더 깔끔하고 더 좋은 것 같습니다! 고생하셨습니다 :) |
JaeHyuckSa
approved these changes
Oct 30, 2023
simseulnyang
approved these changes
Oct 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저는 이 부분에 대한 공부가 필요해서 코드가 어떻게 작성되었는지만 확인했습니다.
다양한 방법이 있다는 사실을 깨달았습니다! 또 배웠네요 감사합니다!😀
그리고 작업 하시느라 수고 많으셨어요!
lfoyh6591
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 체크리스트
아래 항목을 확인해 주세요:
PR 유형
이 PR은 어떤 종류의 변경을 가져오나요?
현재 동작은 무엇인가요?
이슈 번호: N/A
새로운 동작은 무엇인가요?
이 PR은 호환성 변경을 도입하나요?
기타 정보