Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Add publish button" and "Delete post" sections #181

Merged
merged 5 commits into from
Sep 21, 2024

Conversation

kewtree1408
Copy link
Contributor

Fixes issue: #180

I'm not sure who should I add as a reviewer.
Do you know what should I do with other languages? I see that csrf token, for example, was added only to "en" version of the tutorial.

@das-g
Copy link
Member

das-g commented Sep 19, 2024

I'm not sure who should I add as a reviewer.

You don't have to add any. Potential reviewers can also add themselves.

@das-g
Copy link
Member

das-g commented Sep 19, 2024

Do you know what should I do with other languages?

I don't remember whether we have Crowdin for the extensions now. If not, could you apply your changes to the other languages, too? As these changes are all only in the code blocks, that should be possible without having to know those languages.

@kewtree1408
Copy link
Contributor Author

Hey @das-g ,

Thanks for your comments!

I've changed the code for all of the translations.
I've also removed all glyphicons classes, because they aren't supported in Bootstrap 5, as was mentioned in this issue as well: #145
and was partially changed and mentioned in this PR: #179

Let me know if other changes needed!

Copy link
Member

@das-g das-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@das-g das-g merged commit 2b1577d into DjangoGirls:master Sep 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants