Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre commit #36

Merged
merged 5 commits into from
Mar 17, 2022
Merged

Add pre commit #36

merged 5 commits into from
Mar 17, 2022

Conversation

DocOtak
Copy link
Owner

@DocOtak DocOtak commented Mar 17, 2022

So far I've only added black as a pre-commit hook. Eventually we'll probably add mypy and maybe a linter like flake8.

For this first round do we want isort or something like it?

@DocOtak DocOtak requested a review from rcaneill March 17, 2022 03:50
@rcaneill
Copy link
Collaborator

Nice!
I am not sure that mypy would be essential for a project as small but why not. I never used it but I'll be happy to see how it is used if necessary.
flake8 and isort would also be great!

Copy link
Collaborator

@rcaneill rcaneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me!
Have you tested that the black test fails if a file is not formatted correctly? Should work, but if you haven't tested it quickly, I think it is good to do it before merge

@DocOtak
Copy link
Owner Author

DocOtak commented Mar 17, 2022

Just tried it, CI failed as expected (yay)

@DocOtak DocOtak linked an issue Mar 17, 2022 that may be closed by this pull request
6 tasks
@DocOtak DocOtak merged commit 934701d into master Mar 17, 2022
@DocOtak
Copy link
Owner Author

DocOtak commented Mar 17, 2022

So I think the only thing left for our 0.2.0 release are some docs, I haven't had a chance to work on them since I made that test PR. Hopefully this weekend or next week for getting those a little more... useful.

Do you consider anything else blocking?

@rcaneill
Copy link
Collaborator

According to the milestone, the docs are the only thing left, and I don't see anything else blocking the release.
I you don't want / don't have time to write the docs, I can write all or a part of it, just let me know in #10 what you do and what I do

@rcaneill rcaneill deleted the pre-commit branch May 29, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project Setup Tasks
2 participants