-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pre commit #36
Add pre commit #36
Conversation
Nice! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me!
Have you tested that the black test fails if a file is not formatted correctly? Should work, but if you haven't tested it quickly, I think it is good to do it before merge
Just tried it, CI failed as expected (yay) |
So I think the only thing left for our 0.2.0 release are some docs, I haven't had a chance to work on them since I made that test PR. Hopefully this weekend or next week for getting those a little more... useful. Do you consider anything else blocking? |
According to the milestone, the docs are the only thing left, and I don't see anything else blocking the release. |
So far I've only added black as a pre-commit hook. Eventually we'll probably add mypy and maybe a linter like flake8.
For this first round do we want isort or something like it?