Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update grammar to support complex indices for macros #59

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Update grammar to support complex indices for macros #59

merged 2 commits into from
Nov 28, 2023

Conversation

siefkenj
Copy link
Contributor

No description provided.

dqnykamp
dqnykamp requested changes Nov 27, 2023
View reviewed changes
Copy link
Member

@dqnykamp dqnykamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test where you have an index containing multiple entries including macros, function macros, and/or text, such as $x[2$y$$f(3)]?

@siefkenj
Copy link
Contributor Author

Done!

dqnykamp
dqnykamp approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@dqnykamp dqnykamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@dqnykamp dqnykamp merged commit a03aa89 into Doenet:main Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dqnykamp dqnykamp dqnykamp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@siefkenj @dqnykamp