Skip to content

Comments

feat: implement multisig security layer and pet ownership history #151

Open
mansory-01 wants to merge 5 commits intoDogStark:mainfrom
mansory-01:main
Open

feat: implement multisig security layer and pet ownership history #151
mansory-01 wants to merge 5 commits intoDogStark:mainfrom
mansory-01:main

Conversation

@mansory-01
Copy link

This PR implements multisignature (MultiSig) security system for operations and a tracking system for pet ownership history.


Changes

Multi-Admin Security (MultiSig)

  • Decentralized Governance — Transitioned from a single-admin model to a multi-administrator system with a configurable approval threshold
  • Structured Proposals — Introduced a propose → approve → execute workflow for sensitive actions including Contract Upgrades, Vet Verification, and Admin Changes.
  • Security Safeguards — Each proposal includes a configurable expiry time and strict authorization checks using standard Soroban require_auth() patterns.

Ownership History Tracking

  • Immutable Lineage — Implemented a tracking system that records every ownership transfer, capturing the previous owner, new owner, timestamp, and transfer reason.
  • Transfer-Acceptance Flow — Updated pet transfer logic to require the new owner's explicit acceptance, ensuring transparency and preventing accidental transfers.

Code Quality & Compatibility

  • Soroban Best Practices — Refactored enums to use tuple variants for better compatibility with #[contracttype].

Checklist

  • Implement MultiSig infrastructure (propose_action, approve_proposal, execute_proposal)
  • Integrate MultiSig into critical paths (Vet registration and license revocation)
  • Add ownership history recording to the accept_pet_transfer flow
  • Implement get_ownership_history for full record auditability
  • Add unit tests covering thresholds, expiries, and history tracking
  • closes #119
    closes #115

    Screenshot 2026-02-21 031359

Copy link
Contributor

@llinsss llinsss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plese you have alot of conflicts. kindly resolve

Copy link
Contributor

@llinsss llinsss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have merge conflicts. please resolve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Pet Ownership Transfer Implement Role-Based Access Control

2 participants