Bugfix for #32206 and #32207 #32209
Open
Bugfix for #32206 and #32207 #32209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldy
reviewed
Dec 8, 2024
| @@ -2638,6 +2638,13 @@ public function insert_discount($idremise) | |||
| $facligne->multicurrency_total_tva = -$remise->multicurrency_amount_tva; | |||
| $facligne->multicurrency_total_ttc = -$remise->multicurrency_amount_ttc; | |||
|
|
|||
| //Bugfix#32206 - Incorrect Discounts or Credit is applied in a multicurrency Invoice | |||
| if ($this->multicurrency_tx > 0) { | |||
There was a problem hiding this comment.
When multicurrency_tx is set, all other fields multicurrency should already contains a value include the rate. So bug shoul be at a higher place.
May be they are not saved correctly into the remise table ?
There was a problem hiding this comment.
Yes you are right, I have created a pull request for this.
#32872
There was a problem hiding this comment.
Also we have to migrate the previous data as well.
eldy
added
the
Discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX
Bug: Incorrect Discounts or Credit is applied in a multicurrency Invoice #32206
Bug: In Multi currency Supplier Order Multi currency buying price is coming as NaN #32207