Expose Callback function in d3-graphviz #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This exposes the underlying `callback` function which is called when the rendering state changes. For large files, it can take a while for the graph to "show", hence this helps creates better progress bars if someone needs them.
Fixed linting issues to ensure all tests passing
Owner
|
Hi @ishan-aws, thanks for the contribution. Would you be able to update the README to include this and potentially an example usage to illustrate how it might be useful? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes the underlying
callbackfunction which is called when the rendering state changes. For large files, it can take a while for the graph to "show", hence this helps creates better progress bars if someone needs them.This is based off the source file:
https://github.com/magjac/d3-graphviz/blob/master/src/renderDot.js