personal shuttle order console now actually checks if you can interact with it#889
Open
Paxilmaniac wants to merge 1 commit intoDopplerShift13:masterfrom
Open
Conversation
00-Steven
reviewed
Feb 23, 2026
Comment on lines
114
to
118
| /obj/machinery/computer/personal_shuttle_order/ui_interact(mob/user, datum/tgui/ui) | ||
| . = ..() | ||
| if(!can_interact(user)) | ||
| return | ||
| if(!our_docking_port) |
Collaborator
There was a problem hiding this comment.
all this shouldn't be on ui_interact(...) in the first place, given it's not a proper tgui window- and this proc would handling opening/updating it, not acting upon it
attack_hand(...) or interact(...) would probably serve better, probably the latter due to the can_interact(...) check involved
(note that admin ghosts get to in some cases bypass interact(...) limitations, which may matter in testing)
Collaborator
There was a problem hiding this comment.
probably also returning TRUE so it doesn't try to continue other hand stuff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
adds can interact check to the order console, to prevent ghosts and those without hands from messing with it
fixes #720
Why It's Good For The Game
ghosts could like technically mess with your shuttle order if they really wanted
Changelog
🆑
fix: you cannot interact with the shuttle order console if you cannot interact with things
/:cl: