fixed Entity.Dispose when using multiple EntityMap/MultiMap with the …

…same component key (fix #123)
Doraku · Jul 27, 2021 · 9aa503c · 9aa503c
1 parent ce21ac2
commit 9aa503c
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 3 deletions.
diff --git a/documentation/NEXT_RELEASENOTES.txt b/documentation/NEXT_RELEASENOTES.txt
@@ -0,0 +1 @@
+fixed Entity.Dispose when using multiple EntityMap/MultiMap with the same component key (#123)
diff --git a/source/DefaultEcs/EntityQueryBuilder.cs b/source/DefaultEcs/EntityQueryBuilder.cs
@@ -355,7 +355,7 @@ internal EntityQueryBuilder(World world, bool withEnabledEntities)
             _nonReactSubscriptions = new List<Func<EntityContainerWatcher, World, IDisposable>>();
 
             _addCreated = withEnabledEntities;
-            _subscriptions.Add((s, w) => w.Subscribe<EntityDisposedMessage>(s.Remove));
+            _subscriptions.Add((s, w) => w.Subscribe<EntityDisposingMessage>(s.Remove));
             _withFilter[World.IsAliveFlag] = true;
             if (withEnabledEntities)
             {

diff --git a/source/DefaultEcs/Technical/EntityContainerWatcher.cs b/source/DefaultEcs/Technical/EntityContainerWatcher.cs
@@ -101,7 +101,7 @@ public void CheckedAdd<T>(in ComponentDisabledMessage<T> message)
             }
         }
 
-        public void Remove(in EntityDisposedMessage message) => _container.Remove(message.EntityId);
+        public void Remove(in EntityDisposingMessage message) => _container.Remove(message.EntityId);
 
         public void Remove(in EntityEnabledMessage message) => _container.Remove(message.EntityId);
 

diff --git a/source/DefaultEcs/World.cs b/source/DefaultEcs/World.cs
@@ -479,7 +479,7 @@ public IDisposable SubscribeEntityDisposed(EntityDisposedHandler action)
         {
             IEnumerable<IDisposable> GetSubscriptions(EntityDisposedHandler a)
             {
-                yield return Subscribe((in EntityDisposingMessage message) => action(new Entity(WorldId, message.EntityId)));
+                yield return Subscribe((in EntityDisposingMessage message) => a(new Entity(WorldId, message.EntityId)));
                 yield return Subscribe((in WorldDisposedMessage _) =>
                 {
                     foreach (Entity entity in this)