Fix (re-)oin issues #148
Merged
Fix (re-)oin issues #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this fixes issue DotBots#147 of intermitent node leave/re-join
Contributor
100 nodes join in 6.5 seconds in average, with one node left once at 4:40 mins |
geonnave
changed the title
Contributor
Author
|
Perfect, thanks for testing! Before I merge, could you test handover? |
Contributor
|
With help from @WilliamTakeshi , we tested the handover with 100 nodes and 2 gateways. We did the test three times, and I saw once one node was blinking without joining the closer gateway. 100 nodes finished the handover in around 12 seconds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #147
Includes:
Testing of Node / Gateway (if applicable)
TODO @ysong02
___nodes and___gateways.___