Skip to content

Commit

Permalink
Fix tests
Browse files Browse the repository at this point in the history
  • Loading branch information
Muhammad Rehan Saeed committed Jul 5, 2019
1 parent de50e4d commit 162dc79
Show file tree
Hide file tree
Showing 5 changed files with 245 additions and 542 deletions.
2 changes: 1 addition & 1 deletion Source/Boxed.AspNetCore.TagHelpers/Twitter/Cards/TwitterCardPlayer.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ protected override void Validate()
throw new ValidationException(FormattableString.Invariant($"{nameof(this.Title)} cannot be null or empty."));
}

// ToDo: Add Check for Image.Alt if this.Player.StreamUrl is provided
// TODO: Add Check for Image.Alt if this.Player.StreamUrl is provided
if (this.Player == null)
{
throw new ValidationException(FormattableString.Invariant($"{nameof(this.Player)} cannot be null."));
Expand Down
139 changes: 49 additions & 90 deletions Tests/Boxed.AspNetCore.TagHelpers.Test/Twitter/Cards/TwitterCardAppTest.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ namespace Boxed.AspNetCore.TagHelpers.Test.Twitter.Cards
{
using System;
using System.Collections.Generic;
using System.ComponentModel.DataAnnotations;
using System.Threading.Tasks;
using Boxed.AspNetCore.TagHelpers.Test.TestData;
using Boxed.AspNetCore.TagHelpers.Twitter;
Expand Down Expand Up @@ -37,7 +38,8 @@ public void RenderMetaTags_NoValueForGooglePlay_ExceptionThrown()
return Task.FromResult<TagHelperContent>(tagHelperContent);
});

Assert.Throws<ArgumentNullException>("GooglePlay", () => tagHelper.Process(context, output));
var validationException = Assert.Throws<ValidationException>(() => tagHelper.Process(context, output));
Assert.Contains(nameof(TwitterCardApp.GooglePlay), validationException.Message);
}

/// <summary>
Expand All @@ -46,43 +48,29 @@ public void RenderMetaTags_NoValueForGooglePlay_ExceptionThrown()
[Fact]
public void RenderMetaTags_NoValueForIPad_ExceptionThrown()
{
var expected = typeof(System.ArgumentNullException);
Exception thrownException = null;

var tagHelper = new TwitterCardApp()
{
SiteUsername = TwitterCardAnswerKey.SiteUsernameValue,
IPhone = "307234931",
IPad = string.Empty,
GooglePlay = "com.android.app"
};
var context = new TagHelperContext(
new TagHelperAttributeList(),
new Dictionary<object, object>(),
Guid.NewGuid().ToString("N"));
var output = new TagHelperOutput(
"meta",
new TagHelperAttributeList(),
(cache, encoder) =>
{
var tagHelperContent = new DefaultTagHelperContent();
tagHelperContent.SetContent(string.Empty);
return Task.FromResult<TagHelperContent>(tagHelperContent);
});

try
{
var context = new TagHelperContext(
new TagHelperAttributeList(),
new Dictionary<object, object>(),
Guid.NewGuid().ToString("N"));

var output = new TagHelperOutput(
"meta",
new TagHelperAttributeList(),
(cache, encoder) =>
{
var tagHelperContent = new DefaultTagHelperContent();
tagHelperContent.SetContent(string.Empty);
return Task.FromResult<TagHelperContent>(tagHelperContent);
});

tagHelper.Process(context, output);
}
catch (Exception e)
{
thrownException = e;
}

Assert.Equal(expected, thrownException.GetType());
Assert.Equal("IPad", ((System.ArgumentException)thrownException).ParamName.ToString());
var validationException = Assert.Throws<ValidationException>(() => tagHelper.Process(context, output));
Assert.Contains(nameof(TwitterCardApp.IPad), validationException.Message);
}

/// <summary>
Expand All @@ -91,43 +79,29 @@ public void RenderMetaTags_NoValueForIPad_ExceptionThrown()
[Fact]
public void RenderMetaTags_NoValueForSiteUsername_ExceptionThrown()
{
var expected = typeof(System.ArgumentNullException);
Exception thrownException = null;

var tagHelper = new TwitterCardApp()
{
SiteUsername = string.Empty,
IPhone = "307234931",
IPad = "307234931",
GooglePlay = "com.android.app"
};
var context = new TagHelperContext(
new TagHelperAttributeList(),
new Dictionary<object, object>(),
Guid.NewGuid().ToString("N"));
var output = new TagHelperOutput(
"meta",
new TagHelperAttributeList(),
(cache, encoder) =>
{
var tagHelperContent = new DefaultTagHelperContent();
tagHelperContent.SetContent(string.Empty);
return Task.FromResult<TagHelperContent>(tagHelperContent);
});

try
{
var context = new TagHelperContext(
new TagHelperAttributeList(),
new Dictionary<object, object>(),
Guid.NewGuid().ToString("N"));

var output = new TagHelperOutput(
"meta",
new TagHelperAttributeList(),
(cache, encoder) =>
{
var tagHelperContent = new DefaultTagHelperContent();
tagHelperContent.SetContent(string.Empty);
return Task.FromResult<TagHelperContent>(tagHelperContent);
});

tagHelper.Process(context, output);
}
catch (Exception e)
{
thrownException = e;
}

Assert.Equal(expected, thrownException.GetType());
Assert.Equal("SiteUsername", ((System.ArgumentException)thrownException).ParamName.ToString());
var validationException = Assert.Throws<ValidationException>(() => tagHelper.Process(context, output));
Assert.Contains(nameof(TwitterCardApp.SiteUsername), validationException.Message);
}

/// <summary>
Expand All @@ -143,12 +117,10 @@ public void RenderMetaTags_RenderedCorrectTwitterCardTypeTag_Match()
IPad = "307234931",
GooglePlay = "com.android.app"
};

var context = new TagHelperContext(
new TagHelperAttributeList(),
new Dictionary<object, object>(),
Guid.NewGuid().ToString("N"));

var output = new TagHelperOutput(
"meta",
new TagHelperAttributeList(),
Expand All @@ -160,6 +132,7 @@ public void RenderMetaTags_RenderedCorrectTwitterCardTypeTag_Match()
});

tagHelper.Process(context, output);

Assert.Contains("name=\"twitter:card\" content=\"app\"", output.Content.GetContent());
}

Expand All @@ -170,43 +143,29 @@ public void RenderMetaTags_RenderedCorrectTwitterCardTypeTag_Match()
[Fact]
public void TwitterCard_App_Validation_Fails_Missing_IPhone()
{
var expected = typeof(System.ArgumentNullException);
Exception thrownException = null;

var tagHelper = new TwitterCardApp()
{
SiteUsername = TwitterCardAnswerKey.SiteUsernameValue,
IPhone = string.Empty,
IPad = "307234931",
GooglePlay = "com.android.app"
};
var context = new TagHelperContext(
new TagHelperAttributeList(),
new Dictionary<object, object>(),
Guid.NewGuid().ToString("N"));
var output = new TagHelperOutput(
"meta",
new TagHelperAttributeList(),
(cache, encoder) =>
{
var tagHelperContent = new DefaultTagHelperContent();
tagHelperContent.SetContent(string.Empty);
return Task.FromResult<TagHelperContent>(tagHelperContent);
});

try
{
var context = new TagHelperContext(
new TagHelperAttributeList(),
new Dictionary<object, object>(),
Guid.NewGuid().ToString("N"));

var output = new TagHelperOutput(
"meta",
new TagHelperAttributeList(),
(cache, encoder) =>
{
var tagHelperContent = new DefaultTagHelperContent();
tagHelperContent.SetContent(string.Empty);
return Task.FromResult<TagHelperContent>(tagHelperContent);
});

tagHelper.Process(context, output);
}
catch (Exception e)
{
thrownException = e;
}

Assert.Equal(expected, thrownException.GetType());
Assert.Equal("IPhone", ((System.ArgumentException)thrownException).ParamName.ToString());
var validationException = Assert.Throws<ValidationException>(() => tagHelper.Process(context, output));
Assert.Contains(nameof(TwitterCardApp.IPhone), validationException.Message);
}
}
}
Loading

0 comments on commit 162dc79

Please sign in to comment.