fix server crash because of players thread

DrMeepso · Nov 29, 2024 · 088ec91 · 088ec91
1 parent e609aa0
commit 088ec91
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/Cove/Server/Server.Utils.Networking.cs b/Cove/Server/Server.Utils.Networking.cs
@@ -39,7 +39,7 @@ public void sendPacketToPlayers(Dictionary<string, object> packet)
         {
             byte[] packetBytes = writePacket(packet);
 
-            foreach (CSteamID player in getAllPlayers().ToList())
+            foreach (CSteamID player in getAllPlayers())
             {
                 if (player == SteamUser.GetSteamID())
                     continue;
@@ -56,12 +56,14 @@ public void sendPacketToPlayer(Dictionary<string, object> packet, CSteamID id)
 
         public CSteamID[] getAllPlayers()
         {
-            int playerCount = AllPlayers.Count;
+            WFPlayer[] AllPlayersNow = AllPlayers.ToArray();
+
+            int playerCount = AllPlayersNow.Length;
             CSteamID[] players = new CSteamID[playerCount];
 
             for (int i = 0; i < playerCount; i++)
             {
-                players[i] = AllPlayers[i].SteamId;
+                players[i] = AllPlayersNow[i].SteamId;
             }
 
             return players;

diff --git a/Cove/Server/Server.cs b/Cove/Server/Server.cs
@@ -22,6 +22,7 @@ limitations under the License.
 using Cove.Server.HostedServices;
 using Microsoft.Extensions.Logging;
 using Vector3 = Cove.GodotFormat.Vector3;
+using System.Reflection;
 
 namespace Cove.Server
 {
@@ -303,7 +304,6 @@ public void Init()
                         Console.WriteLine("This will cause issues, please run the server on a different account!");
                         Console.ResetColor();
                     }
-
                 }
 
                 if (stateChange.HasFlag(EChatMemberStateChange.k_EChatMemberStateChangeLeft) || stateChange.HasFlag(EChatMemberStateChange.k_EChatMemberStateChangeDisconnected))