feat(main): 引入多线程读取 ctl 命名管道，用信号机制改写 service 和 task 的状态检查 #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
val213
changed the title
fslongjin
reviewed
Nov 12, 2024
src/manager/mod.rs
Outdated
Comment on lines
84
to
85
| if SIGCHILD_SIGNAL_RECEIVED.load(Ordering::SeqCst) { | ||
| SIGCHILD_SIGNAL_RECEIVED.store(false, Ordering::SeqCst); |
There was a problem hiding this comment.
这里用compare and exchange才对。否则可能有并发安全问题
if SIGCHILD_SIGNAL_RECEIVED.compare_exchange(true, false, Ordering::SeqCst, Ordering::SeqCst) {
.........
}
fslongjin
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
需求：#46
原本当前主线的 test_ebpf 结果（55e6f0b65f91b32638fd56581f711a816eccdcd1）：
本分支修改后的 test_ebpf 结果
注释掉 dragonreach 主进程下 loop 内容后，当前主线下 test_ebpf 结果