Simulator #2470
Merged
Simulator #2470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Herklos
approved these changes
Nov 15, 2023
| @@ -133,3 +138,13 @@ def format_portfolio_history(history: dict, unit: str, portfolio_id: str) -> lis | |||
| ] | |||
| except KeyError: | |||
| return [] | |||
|
|
|||
|
|
|||
| def get_adapted_portfolio(usd_like_asset, portfolio): | |||
| portfolio = (bot_config.get( | ||
| enums.BotConfigKeys.OPTIONS.value | ||
| ) or {}).get("portfolio") | ||
| usd_like_asset = "USDT" # todo use dynamic value when exchange is not supporting USDT |
There was a problem hiding this comment.
Could we use the strategy reference market if it's an usd like asset?
GuillaumeDSM
force-pushed
the
simulator
branch
from
3d73b5e to
7a1dbd3
Compare
Herklos
approved these changes
Nov 15, 2023
Comment on lines
+273
to
+274
| if trading_api.is_usd_like_coin(profile_data.trading.reference_market): | ||
| usd_like_asset = profile_data.trading.reference_market |
Herklos
approved these changes
Nov 15, 2023
Herklos
approved these changes
Nov 16, 2023
Herklos
reviewed
Nov 16, 2023
| async def refresh_selected_bot_if_unset(self): | ||
| if not self.user_account.has_selected_bot_data(): | ||
| self.user_account.set_selected_bot_raw_data( | ||
| await self.supabase_client.fetch_bot(self.user_account.bot_id) |
There was a problem hiding this comment.
Should we also check that self.user_account.bot_id is not None ?
There was a problem hiding this comment.
it's initialized in constructor, it should never be None, we are fine :)
Herklos
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.