Merged
Conversation
Comment on lines
60
to
67
| } catch (GeneralException generalException) { | ||
| log.info( | ||
| "[EVENT-LISTENER-CUSTOM] Method: {}, Code: {}, Message: {}, Duration: {}ms", | ||
| methodName, | ||
| generalException.getErrorStatus().getCode(), | ||
| generalException.getMessage(), | ||
| calculateDuration(start)); | ||
| throw generalException; |
Member
There was a problem hiding this comment.
EvnetHandler에서 생기는 GeneralException 은 서비스에서 동일하게 생겨서 중복으로 로그를 남길지 논의가 필요할거같습니다!
Member
Author
There was a problem hiding this comment.
GeneralException은 서비스에서만 로그를 남기는게 좋은 것 같습니다! 수정할게요
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🌱 관련 이슈
close #477
📌 작업 내용 및 특이사항
📝 참고사항
📚 기타
정상 응답 로깅(인텔리제이)
정상 응답 로깅(그라파나)
예외처리 로깅(인텔리제이)
예외처리 로깅(그라파나)
