Extract kover configurations into a build-logic plugin

DroidKaigi · Sep 6, 2023 · f35f299 · f35f299
1 parent 4001add
commit f35f299
Show file tree

Hide file tree

Showing 12 changed files with 13 additions and 37 deletions.
diff --git a/app-android/build.gradle.kts b/app-android/build.gradle.kts
@@ -10,7 +10,7 @@ plugins {
     id("droidkaigi.primitive.android.crashlytics")
     id("droidkaigi.primitive.detekt")
     id("droidkaigi.primitive.android.roborazzi")
-    id("droidkaigi.primitive.kover")
+    id("droidkaigi.primitive.kover.entrypoint")
     id("droidkaigi.primitive.android.osslicenses")
 }
 
@@ -116,25 +116,3 @@ dependencies {
     implementation(libs.firebaseDynamicLinks)
     testImplementation(projects.core.testing)
 }
-
-// Dependency configuration to aggregate Kover coverage reports
-// TODO: extract report aggregation to build-logic
-dependencies {
-    kover(projects.appIosShared)
-
-    kover(projects.feature.about)
-    kover(projects.feature.contributors)
-    kover(projects.feature.floorMap)
-    kover(projects.feature.main)
-    kover(projects.feature.sessions)
-    kover(projects.feature.sponsors)
-    kover(projects.feature.staff)
-    kover(projects.feature.achievements)
-
-    kover(projects.core.common)
-    kover(projects.core.data)
-    kover(projects.core.designsystem)
-    kover(projects.core.model)
-    kover(projects.core.testing)
-    kover(projects.core.ui)
-}
diff --git a/app-ios-shared/build.gradle.kts b/app-ios-shared/build.gradle.kts
@@ -5,7 +5,6 @@ import org.jetbrains.kotlin.gradle.plugin.mpp.apple.XCFramework
 plugins {
     id("droidkaigi.primitive.kmp")
     id("droidkaigi.primitive.kmp.ios")
-    id("droidkaigi.primitive.kover")
 }
 
 kotlin {

diff --git a/build-logic/build.gradle.kts b/build-logic/build.gradle.kts
@@ -94,9 +94,9 @@ gradlePlugin {
             id = "droidkaigi.primitive.kmp.serialization"
             implementationClass = "io.github.droidkaigi.confsched2023.primitive.KotlinSerializationPlugin"
         }
-        register("kover") {
-            id = "droidkaigi.primitive.kover"
-            implementationClass = "io.github.droidkaigi.confsched2023.primitive.KoverPlugin"
+        register("koverEntryPoint") {
+            id = "droidkaigi.primitive.kover.entrypoint"
+            implementationClass = "io.github.droidkaigi.confsched2023.primitive.KoverEntryPointPlugin"
         }
         register("detekt") {
             id = "droidkaigi.primitive.detekt"

diff --git a/...gic/src/main/kotlin/io/github/droidkaigi/confsched2023/convention/AndroidFeaturePlugin.kt b/...gic/src/main/kotlin/io/github/droidkaigi/confsched2023/convention/AndroidFeaturePlugin.kt
@@ -14,7 +14,6 @@ class AndroidFeaturePlugin : Plugin<Project> {
                 apply("droidkaigi.primitive.android.compose")
                 apply("droidkaigi.primitive.android.hilt")
                 apply("droidkaigi.primitive.android.roborazzi")
-                apply("droidkaigi.primitive.kover")
                 apply("droidkaigi.primitive.detekt")
             }
 

diff --git a/...gi/confsched2023/primitive/KoverPlugin.kt → ...ed2023/primitive/KoverEntryPointPlugin.kt b/...gi/confsched2023/primitive/KoverPlugin.kt → ...ed2023/primitive/KoverEntryPointPlugin.kt
@@ -5,10 +5,17 @@ import org.gradle.api.Plugin
 import org.gradle.api.Project
 import org.gradle.kotlin.dsl.configure
 
-class KoverPlugin : Plugin<Project> {
+class KoverEntryPointPlugin : Plugin<Project> {
     override fun apply(target: Project) {
+        val koverPlugin = "org.jetbrains.kotlinx.kover"
         with(target) {
-            pluginManager.apply("org.jetbrains.kotlinx.kover")
+            pluginManager.apply(koverPlugin)
+
+            rootProject.subprojects {
+                if (this@subprojects.name == target.name) return@subprojects
+                this@subprojects.pluginManager.apply(koverPlugin)
+                target.dependencies.add("kover", this@subprojects)
+            }
 
             configure<KoverReportExtension> {
                 filters {

diff --git a/core/common/build.gradle.kts b/core/common/build.gradle.kts
@@ -3,7 +3,6 @@ plugins {
     id("droidkaigi.primitive.kmp.android")
     id("droidkaigi.primitive.kmp.ios")
     id("droidkaigi.primitive.kmp.android.hilt")
-    id("droidkaigi.primitive.kover")
     id("droidkaigi.primitive.detekt")
 }
 

diff --git a/core/data/build.gradle.kts b/core/data/build.gradle.kts
@@ -6,7 +6,6 @@ plugins {
     id("droidkaigi.primitive.detekt")
     id("droidkaigi.primitive.kmp.ktorfit")
     id("droidkaigi.primitive.kmp.serialization")
-    id("droidkaigi.primitive.kover")
 }
 
 android.namespace = "io.github.droidkaigi.confsched2023.core.data"

diff --git a/core/designsystem/build.gradle.kts b/core/designsystem/build.gradle.kts
@@ -6,7 +6,6 @@ plugins {
     id("droidkaigi.primitive.kmp.android.hilt")
     id("droidkaigi.primitive.detekt")
     id("droidkaigi.primitive.kmp.android.showkase")
-    id("droidkaigi.primitive.kover")
 }
 
 android.namespace = "io.github.droidkaigi.confsched2023.core.designsystem"

diff --git a/core/model/build.gradle.kts b/core/model/build.gradle.kts
@@ -2,7 +2,6 @@ plugins {
     id("droidkaigi.primitive.kmp")
     id("droidkaigi.primitive.kmp.android")
     id("droidkaigi.primitive.kmp.ios")
-    id("droidkaigi.primitive.kover")
     id("droidkaigi.primitive.detekt")
 }
 

diff --git a/core/testing/build.gradle.kts b/core/testing/build.gradle.kts
@@ -3,7 +3,6 @@ plugins {
     id("droidkaigi.primitive.android.kotlin")
     id("droidkaigi.primitive.android.compose")
     id("droidkaigi.primitive.android.hilt")
-    id("droidkaigi.primitive.kover")
     id("droidkaigi.primitive.detekt")
 }
 

diff --git a/core/ui/build.gradle.kts b/core/ui/build.gradle.kts
@@ -4,7 +4,6 @@ plugins {
     id("droidkaigi.primitive.kmp.ios")
     id("droidkaigi.primitive.kmp.compose")
     id("droidkaigi.primitive.kmp.android.hilt")
-    id("droidkaigi.primitive.kover")
     id("droidkaigi.primitive.detekt")
 }
 

diff --git a/feature/contributors/build.gradle.kts b/feature/contributors/build.gradle.kts
@@ -4,7 +4,6 @@ plugins {
     id("droidkaigi.primitive.kmp.android.hilt")
     id("droidkaigi.primitive.kmp.ios")
     id("droidkaigi.primitive.kmp.compose")
-    id("droidkaigi.primitive.kover")
 }
 
 android.namespace = "io.github.droidkaigi.confsched2023.feature.contributors"