Initial implementation of updating Livneh weather DB extraction #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Created new branch * Changed demo/ and TestPrj4/ description files so user can choose between versions * Updated extract_daily_weather_from_livneh with version argument and pertinent if ... statement * Other arguments within WeatherDB.R for additional data source including finding ids and paths.
Codecov Report
@@ Coverage Diff @@
## master #331 +/- ##
==========================================
- Coverage 48.01% 47.87% -0.14%
==========================================
Files 40 40
Lines 16627 16679 +52
==========================================
+ Hits 7983 7985 +2
- Misses 8644 8694 +50
Continue to review full report at Codecov.
|
dschlaep
requested changes
Sep 10, 2018
There was a problem hiding this comment.
Output from lintr checks test_file("tests/testthat/test_rSFSW2_StyleSpelllingPractices.R"):
test_rSFSW2_StyleSpelllingPractices.R:29: failure: Package code style
Not lint free
R/WeatherDB.R:281:24: style: Only use double-quotes.
version = 'v2013',
^~~~~~~
R/WeatherDB.R:300:24: style: Only use double-quotes.
version = 'v2016',
^~~~~~~
R/WeatherDB.R:1451:5: style: Place a space before left parenthesis, except in a function call.
if(version == 'v2013') {
^
R/WeatherDB.R:1451:17: style: Only use double-quotes.
if(version == 'v2013') {
^~~~~~~
R/WeatherDB.R:1452:21: style: Use <-, not =, for assignment.
end_year_livneh = 2011
^
R/WeatherDB.R:1457:5: style: Place a space before left parenthesis, except in a function call.
if(version == 'v2016') {
^
R/WeatherDB.R:1457:17: style: Only use double-quotes.
if(version == 'v2016') {
^~~~~~~
R/WeatherDB.R:1458:21: style: Use <-, not =, for assignment.
end_year_livneh = 2015
^
R/WeatherDB.R:1464:1: style: Lines should not be more than 80 characters.
has_start_year = 1915, has_end_year = end_year_livneh, temp_call = temp_call,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
R/WeatherDB.R:1500:22: style: Only use double-quotes.
if (version == 'v2013') {
^~~~~~~
R/WeatherDB.R:1507:22: style: Only use double-quotes.
if (version == 'v2016') {
^~~~~~~
tests/test_data/TestPrj4/SFSW2_project_descriptions.R:160:13: style: Commented code should be removed.
# file.path(project_paths[["dir_ex_weather"]], "Livneh_NA_2016")
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| temp <- unlist(lapply(temp, function(x) | ||
| if (length(x) == 3 && x[3] == "nc") x[2])) | ||
|
|
||
| db_months <- formatC(SFSW2_glovars[["st_mo"]], width = 2, flag = "0") |
There was a problem hiding this comment.
This line is exact repeat from line 1504. Move after if (version == ...) {}.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
between versions
pertinent if ... statement
finding ids and paths.