States ash prep #117
Merged
States ash prep #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: KP <86213869+Kanishk-Pandey@users.noreply.github.com>
Signed-off-by: KP <86213869+Kanishk-Pandey@users.noreply.github.com>
Signed-off-by: KP <86213869+Kanishk-Pandey@users.noreply.github.com>
a1cd
requested changes
Mar 27, 2024
Comment on lines
+413
to
+415
| driverController | ||
| .a() | ||
| .whileTrue(FeederCommands.feedToShooter(feeder)); |
There was a problem hiding this comment.
You can put this on the operator controller but right now we are trying to reduce the number of controls on the drivers controller
Comment on lines
+570
to
+572
| .andThen( | ||
| LEDCommands.setIntakeType(leds) | ||
| ) |
There was a problem hiding this comment.
The LEDs are making me confused, if we had the LEDs actually visually indicate up or down then I might approve
| }, shooter) | ||
| .withName("Shooter Idle"); | ||
| } | ||
|
|
||
| public static Command SHOOTLONGWAY (Shooter shooter) { |
There was a problem hiding this comment.
Name? Maybe document this one idk what this is supposed to do
a1cd
requested changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
basic changes