added pass function #122
Closed
added pass function #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GBKP
suggested changes
Apr 3, 2024
| @@ -173,6 +173,15 @@ public static Command simpleHoodZero(Shooter shooter) { | |||
| .withName("Simple Hood Zero"); | |||
| } | |||
|
|
|||
| //https://www.desmos.com/calculator/rcnsmtoqwi hypothetical math | |||
There was a problem hiding this comment.
change to same angle and 1000 rpm
GBKP
approved these changes
Apr 3, 2024
a1cd
approved these changes
Apr 4, 2024
a1cd
suggested changes
Apr 4, 2024
Comment on lines
176
to
183
| public static Command passNote(Shooter shooter) { | ||
| return run(() -> { | ||
| shooter.shooterRunVelocity(1000); | ||
| shooter.setTargetShooterAngle(Rotation2d.fromRadians(.25)); | ||
| }, shooter) | ||
| .withName("passNote"); | ||
| } | ||
|
|
There was a problem hiding this comment.
hold on i actually think we need to also have a feeder command for this, without it we won't actually shoot, so once the shooter is at setpoint you should shoot
…hypothetical-shooter-pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not keyboard to a controller yet