Fix some dependencies for easy installation #47
Merged
+12
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi-king
changed the title
|
@matsui528 Plz review this :) |
Hi-king
commented
Oct 14, 2023
| @@ -13,7 +13,7 @@ jobs: | |||
| max-parallel: 3 | |||
| matrix: | |||
| platform: [ubuntu-latest] | |||
| python-version: [3.5, 3.7, 3.8, 3.9] | |||
| python-version: ["3.7", "3.8", "3.9"] | |||
There was a problem hiding this comment.
shoud be str type (to use 3.10, which currently incompatible with pqkmeans ...)
Hi-king
commented
Oct 14, 2023
| @@ -1,6 +1,5 @@ | |||
| numpy | |||
| numpy<1.21 | |||
There was a problem hiding this comment.
errors occur with recent numpy
Hi-king
commented
Oct 14, 2023
| scikit-learn | ||
| pipe | ||
| pipe<2.0 |
There was a problem hiding this comment.
breaking changes on 2.0
matsui528
approved these changes
Oct 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#46
The old library lshash3 is preventing easy installation of pqkmeans. This library is depended on by texmex-python.
Solution
Move texmex-python to the extras_require section.
Of course, you can also
pip install pqkmeans[texmex](orpip install -e . [texmex]) to install it with texmex.