-
Notifications
You must be signed in to change notification settings - Fork 8
DEV-1787: Updates to OAS from internal testing findings #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| summary: Verify KBA Questions | ||
| description: Submits customer answers to KBA questions for identity verification. Requires four question-answer pairs with questionId and answerId values. Returns verification status indicating whether the customer passed or failed the KBA authentication. | ||
| operationId: verify | ||
| operationId: verifyKbaQuestions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ShreyaThapa would there also need to be a x-speakeasy-group here? Similar to initiateKba
| description: Reallocates funds between two labels belonging to the same Verified Customer. Moves the specified amount from the source label to the destination label, creating ledger entries for both. The reallocation only succeeds if the source label has sufficient funds. | ||
| operationId: createLabelReallocation | ||
| x-speakeasy-name-override: createReallocation | ||
| x-speakeasy-group: labelReallocations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this one be customers.labelReallocation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was debating whether this would be labels.reallocations.create given that its a sub resource of labels, but I ended up going with the what the API path looked like and was hoping you'd have some advice on it:
https://api.dwolla.com/label-reallocations
If we do the <resource>.<sub-resource>, should we consider doing labels.reallocations.create like how we do it for fundingSources.update/fundingSources/remove?
On the other hand customers.labels.reallocations.create also sounds right. This was a hard one to come up with a good naming convention for.
We could do something like what you mentioned and make sure to explicitly mention what the {id} is in the request parameter list and API path -
customers.labels.reallocations.create()customers.labels.reallocations.get( reallocationId )customers.labels.ledgerEntries.list( labelId )customers.labels.ledgerEntries.get( ledgerEntryId )masspayments.items.get( itemId )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@spencerhunter, let me know what you think!
| description: Create a new ledger entry to track fund adjustments on a Label by specifying a positive or negative amount value. Returns the location of the created ledger entry in the response header. Label amounts cannot go negative, so validation errors occur if the entry would result in a negative Label balance. | ||
| operationId: createLabelLedgerEntry | ||
| x-speakeasy-name-override: createLedgerEntry | ||
| x-speakeasy-group: labels.ledgerEntries |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
similar to labelReallocations, should this one be customers.labels.ledgerEntries?
ExchangePartners.ymlschematransferstofundingSources.