Dev 1807: Validate issue with balance response and apply fix #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShreyaThapa
changed the title
gram/overlay.yml
Outdated
| - Customer must exist (use get_customer or list_customers to verify if needed) | ||
| - Choose appropriate funding source creation method based on available data: | ||
| * Use account/routing numbers for traditional manual entry | ||
| * Use Plaid token if bank account was verified through Plaid |
Member
There was a problem hiding this comment.
Should remove plaidToken as an option for this request since it will likely be deprecated at some point in favor of the exchange solution?
gram/overlay.yml
Outdated
| - Choose appropriate funding source creation method based on available data: | ||
| * Use account/routing numbers for traditional manual entry | ||
| * Use Plaid token if bank account was verified through Plaid | ||
| * Use exchange resource if bank was connected via IAV (Instant Account Verification) |
Member
There was a problem hiding this comment.
Suggested change
| * Use exchange resource if bank was connected via IAV (Instant Account Verification) | |
| * Use exchange resource if bank was connected via Instant Account Verification (IAV) through an Open Banking provider (e.g. Plaid, MX, Finicity, Flinks) |
gram/overlay.yml
Outdated
| * Use account/routing numbers for traditional manual entry | ||
| * Use Plaid token if bank account was verified through Plaid | ||
| * Use exchange resource if bank was connected via IAV (Instant Account Verification) | ||
| * Use virtual account type for creating Virtual Account Numbers (VANs) for receiving funds |
Member
There was a problem hiding this comment.
Suggested change
| * Use virtual account type for creating Virtual Account Numbers (VANs) for receiving funds | |
| * Use virtual account type for creating Virtual Account Numbers (VANs) for enabling ACH transactions to and from a Dwolla Balance (digital wallet) |
gram/overlay.yml
Outdated
| <workflow> | ||
| 1. Determine which funding source creation method to use based on available data | ||
| 2. For traditional method: Obtain valid US routing number and account number | ||
| 3. For Plaid method: First obtain a Plaid processor token |
Member
There was a problem hiding this comment.
Similar comment as above. Should we remove plaidToken reference?
gram/overlay.yml
Outdated
| * Use Plaid token if bank account was verified through Plaid | ||
| * Use exchange resource if bank was connected via IAV (Instant Account Verification) | ||
| * Use virtual account type for creating Virtual Account Numbers (VANs) for receiving funds | ||
| - Ensure customer type supports the chosen funding source method |
Member
There was a problem hiding this comment.
Any additional context we can provide here with what we mean by this bullet point?
gram/overlay.yml
Outdated
| 1. Determine which funding source creation method to use based on available data | ||
| 2. For traditional method: Obtain valid US routing number and account number | ||
| 3. For Plaid method: First obtain a Plaid processor token | ||
| 4. For exchange method: First create an exchange session and obtain exchange resource |
Member
There was a problem hiding this comment.
Exchange session isn't always required in order to create a funding source.
gram/overlay.yml
Outdated
| 2. For traditional method: Obtain valid US routing number and account number | ||
| 3. For Plaid method: First obtain a Plaid processor token | ||
| 4. For exchange method: First create an exchange session and obtain exchange resource | ||
| 5. Specify bank account type (checking, savings, or for VANs: checking only) |
Member
There was a problem hiding this comment.
Suggested change
| 5. Specify bank account type (checking, savings, or for VANs: checking only) | |
| 5. Specify bank account type (checking, savings, or for VANs: virtual) |
gram/overlay.yml
Outdated
| Instant Account Verification (IAV) partners like MX, Plaid, or Finicity. | ||
| </context> | ||
| <when_to_use> | ||
| - Customer connected their bank through Dwolla's Open Banking flow |
Member
There was a problem hiding this comment.
Should we include the secure token exchange solution here? These bullets seem to lean towards our Open Banking solution that uses exchange sessions and exchanges.
gram/overlay.yml
Outdated
| - Create an exchange session first (use exchange partner integration) | ||
| - Customer must complete the bank connection through IAV flow | ||
| - Obtain the exchange resource URL from the successful connection | ||
| - Use list_available_connections to see which banks were connected |
Member
There was a problem hiding this comment.
This endpoint/tool is pretty complex which in turn makes it difficult to bullet point pre-requisites. Maybe we should think about this more broadly to start? TLDR; wonder if we should remove this bullet point
| <prerequisites> | ||
| - Customer must be a verified customer with Dwolla Balance access | ||
| - Virtual account type must be set to "virtual" | ||
| - Bank account type must be "checking" (only supported type for VANs) |
spencerhunter
requested changes
Nov 13, 2025
Member
spencerhunter
left a comment
spencerhunter
left a comment
There was a problem hiding this comment.
@ShreyaThapa A few recommendations are ready for review!
spencerhunter
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
retrieveFundingSourceBalance.ymlto fix Zod union discrimination. Without required fields, the validator always matched the first schema, causingavailableandclosingfields to be dropped from Bank Balance responses./gramfolder that houses theoverlay.ymland generateopenapi.ymlfile used in Gram MCPgram/openapi.ymlfile, use the following Speakeasy CLI command:speakeasy overlay apply --overlay=gram/overlay.yml --schema=openapi.yml --out=gram/openapi.ymlverifiedfield definition inCreateCustomerFundingSource.ymlto prevent Speakeasy from generating it as a required field. This allows the Zod union to correctly match the account-numbers schema when creating funding sources with routing/account numbers.