Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Pamela Uzodimma to the cohort-three board #54

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

PamelaUzodimma
Copy link

Kindly review my pull request

Copy link

netlify bot commented Dec 21, 2023

👷 Deploy request for dxmentorshipv2 pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit c1a780a

Copy link

vercel bot commented Dec 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dxmentorship ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 21, 2023 5:27pm
dxmentorship-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 21, 2023 5:27pm
dxmentorship-xle4 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 21, 2023 5:27pm

Copy link
Contributor

@kohasummons kohasummons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good One, @PamelaUzodimma!

@PamelaUzodimma
Copy link
Author

Good One, @PamelaUzodimma!

Thank you.

@kenny-io
Copy link
Collaborator

kenny-io commented Jan 3, 2024

@PamelaUzodimma Well done on this PR! It came fast and mostly worked as expected. The only issue is that your image is broken.

Screenshot 2024-01-03 at 3 01 15 PM

I noticed that your image is in src/assets/ consider moving it into public/assets directory to make it globally available to .md files.

@kenny-io kenny-io self-requested a review January 3, 2024 11:02
@kenny-io kenny-io marked this pull request as draft January 3, 2024 11:02
Copy link
Collaborator

@kenny-io kenny-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PamelaUzodimma thank you sending the PR over

Here are a few things you can do to complete it

[ ] First pull in the new changes we've made in the main branch so that your PR will be up to date with the latest commit.

[ ] Move your image from src/assets/pamela.jpg to public/assets/pamela.jpg
[ ] Move your content file from src/content/cohort/pamela.md to src/content/cohort-3/pamela.md

If any of this is confusing or you need help, join the event in Discord tomorrow for more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants