Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated Node.js version in GitHub action #436

Conversation

jariavikainen
Copy link

samuelmeuli/action-electron-builder@v1 used in the build GitHub action uses a deprecated version 12 of Node.js. The repository doesn't seem to be maintained anymore (samuelmeuli/action-electron-builder#87), but there is another updated source for the same action. This PR switches to the updated source.

Signed-off-by: Jari Avikainen <54018488+jariavikainen@users.noreply.github.com>
@jariavikainen jariavikainen force-pushed the fix-electron-builder-node-version branch from a8bc4b3 to d3edc8d Compare June 8, 2023 06:48
@GazHank
Copy link

GazHank commented Jun 8, 2023

It looks like this new action uses alternative variables for code signing, so it will probably need some changes to use the following variables:

  • mac_certs
  • mac_certs_password
  • windows_certs
  • windows_certs_password

as such it would superseed the PR I raised yesterday #435

ps - would it now be possible to avoid a full build from source for the native modules and simply use the prepackaged NAPI modules instead, this simplify the build process, cut down compile time, and I would think (hope) also simplify troubleshooting of build issues

@AlexDygma
Copy link
Member

Hey there @jariavikainen ! Thanks for your support!

in fact, i already did this in another PR( #417 ) that was yet to be merged, due to a lack of working signing secrets, but as @GazHank said, it's due to the change in naming conventions for the secrets! I will have to change those to make it work 😓

Thanks for the care 🤗! I will close this one as it's duplicated 😶‍🌫️

PS: I will merge the other repo right now with the changes to the secrets 💨

@AlexDygma AlexDygma closed this Jun 16, 2023
@AlexDygma AlexDygma reopened this Jun 16, 2023
@AlexDygma AlexDygma merged commit 95af725 into Dygmalab:development Jun 16, 2023
@AlexDygma
Copy link
Member

I merged this one finally due to the errors when working with the yarn lock file, not worth to repair them xD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants