Optimize code

DylanCaiCoding · Mar 29, 2021 · 98a421f · 98a421f
1 parent 64ed3ca
commit 98a421f
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 17 deletions.
diff --git a/...ing-nonreflection/src/main/java/com/dylanc/viewbinding/nonreflection/BindingViewHolder.kt b/...ing-nonreflection/src/main/java/com/dylanc/viewbinding/nonreflection/BindingViewHolder.kt
@@ -27,7 +27,7 @@ import androidx.viewbinding.ViewBinding
  * @author Dylan Cai
  */
 
-class BindingViewHolder<VB : ViewBinding>(val binding: VB) : RecyclerView.ViewHolder(binding.root) {
+open class BindingViewHolder<VB : ViewBinding>(val binding: VB) : RecyclerView.ViewHolder(binding.root) {
 
   constructor(block: (LayoutInflater, ViewGroup, Boolean) -> VB, parent: ViewGroup) :
       this(block(LayoutInflater.from(parent.context), parent, false))

diff --git a/viewbinding-nonreflection/src/main/java/com/dylanc/viewbinding/nonreflection/ViewBinding.kt b/viewbinding-nonreflection/src/main/java/com/dylanc/viewbinding/nonreflection/ViewBinding.kt
@@ -65,24 +65,23 @@ class FragmentBindingDelegate<VB : ViewBinding>(
   private val bind: (View) -> VB
 ) : ReadOnlyProperty<Fragment, VB> {
 
-  private var lifecycleObserver: LifecycleObserver? = null
+  private var observedLifecycle = false
   private var binding: VB? = null
 
   @Suppress("UNCHECKED_CAST")
   override fun getValue(thisRef: Fragment, property: KProperty<*>): VB {
-    if (lifecycleObserver == null) {
-      lifecycleObserver = object : LifecycleObserver {
+    if (!observedLifecycle) {
+      thisRef.viewLifecycleOwner.lifecycle.addObserver(object : LifecycleObserver {
         @OnLifecycleEvent(Lifecycle.Event.ON_DESTROY)
         fun onDestroyView() {
           binding = null
         }
-      }.also {
-        thisRef.viewLifecycleOwner.lifecycle.addObserver(it)
-      }
+      })
+      observedLifecycle = true
     }
     if (binding == null) {
       binding = bind(thisRef.requireView())
     }
     return binding!!
   }
-}
+}
diff --git a/viewbinding/src/main/java/com/dylanc/viewbinding/BindingViewHolder.kt b/viewbinding/src/main/java/com/dylanc/viewbinding/BindingViewHolder.kt
@@ -30,7 +30,7 @@ import androidx.viewbinding.ViewBinding
 inline fun <reified VB : ViewBinding> BindingViewHolder(parent: ViewGroup) =
   BindingViewHolder(inflateBinding<VB>(parent))
 
-class BindingViewHolder<VB : ViewBinding>(val binding: VB) : RecyclerView.ViewHolder(binding.root) {
+open class BindingViewHolder<VB : ViewBinding>(val binding: VB) : RecyclerView.ViewHolder(binding.root) {
 
   constructor(block: (LayoutInflater, ViewGroup, Boolean) -> VB, parent: ViewGroup) :
       this(block(LayoutInflater.from(parent.context), parent, false))

diff --git a/viewbinding/src/main/java/com/dylanc/viewbinding/ViewBinding.kt b/viewbinding/src/main/java/com/dylanc/viewbinding/ViewBinding.kt
@@ -71,25 +71,24 @@ class FragmentBindingDelegate<VB : ViewBinding>(
   private val clazz: Class<VB>
 ) : ReadOnlyProperty<Fragment, VB> {
 
-  private var lifecycleObserver: LifecycleObserver? = null
+  private var observedLifecycle = false
   private var binding: VB? = null
-  
+
   @Suppress("UNCHECKED_CAST")
   override fun getValue(thisRef: Fragment, property: KProperty<*>): VB {
-    if (lifecycleObserver == null) {
-      lifecycleObserver = object : LifecycleObserver {
+    if (!observedLifecycle) {
+      thisRef.viewLifecycleOwner.lifecycle.addObserver(object : LifecycleObserver {
         @OnLifecycleEvent(Lifecycle.Event.ON_DESTROY)
         fun onDestroyView() {
           binding = null
         }
-      }.also {
-        thisRef.viewLifecycleOwner.lifecycle.addObserver(it)
-      }
+      })
+      observedLifecycle = true
     }
     if (binding == null) {
       binding = clazz.getMethod("bind", View::class.java)
         .invoke(null, thisRef.requireView()) as VB
     }
     return binding!!
   }
-}
+}