Fix code smells

DynamicsValue · Feb 7, 2024 · 2b1092e · 2b1092e
1 parent 47172f1
commit 2b1092e
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 11 deletions.
diff --git a/src/FakeXrmEasy.Core/CommercialLicense/SubscriptionManager.cs b/src/FakeXrmEasy.Core/CommercialLicense/SubscriptionManager.cs
@@ -14,7 +14,6 @@ internal class SubscriptionManager
         internal readonly SubscriptionUsageManager _subscriptionUsageManager;
 
         private bool _renewalRequested = false;
-        private bool _upgradeRequested = false;
 
         private static readonly object _subscriptionManagerLock = new object();
         private static SubscriptionManager _instance = null;
@@ -87,10 +86,9 @@ internal void SetSubscriptionStorageProvider_Internal(ISubscriptionStorageProvid
                     return;
                 }
 
-                _upgradeRequested = upgradeRequested;
                 _renewalRequested = renewalRequested;
 
-                _subscriptionUsage = _subscriptionUsageManager.ReadAndUpdateUsage(_subscriptionInfo, subscriptionStorageProvider, userReader, _upgradeRequested);
+                _subscriptionUsage = _subscriptionUsageManager.ReadAndUpdateUsage(_subscriptionInfo, subscriptionStorageProvider, userReader, upgradeRequested);
             }
         }
         internal void SetSubscriptionStorageProvider(ISubscriptionStorageProvider subscriptionStorageProvider, 

diff --git a/src/FakeXrmEasy.Core/CommercialLicense/SubscriptionValidator.cs b/src/FakeXrmEasy.Core/CommercialLicense/SubscriptionValidator.cs
@@ -118,11 +118,5 @@ internal bool IsUsageValid()
             }
             return true;
         }
-
-        private bool IsRunningInContinuousIntegration()
-        {
-            return "1".Equals(_environmentReader.GetEnvironmentVariable("FAKE_XRM_EASY_CI"))
-                || "True".Equals(_environmentReader.GetEnvironmentVariable("TF_BUILD"));
-        }
     }
 }
diff --git a/tests/FakeXrmEasy.Core.Tests/CommercialLicense/SubscriptionManagerTests.cs b/tests/FakeXrmEasy.Core.Tests/CommercialLicense/SubscriptionManagerTests.cs
@@ -13,8 +13,6 @@ public class SubscriptionManagerTests
     {
         private SubscriptionManager _subscriptionManager;
         private readonly FakeEnvironmentReader _environmentReader;
-        private readonly ISubscriptionInfo _subscriptionInfo;
-        private readonly ISubscriptionUsage _subscriptionUsage;
         private readonly SubscriptionUsageManager _subscriptionUsageManager;
         private readonly ISubscriptionStorageProvider _fakeSubscriptionStorageProvider;
         public SubscriptionManagerTests()