Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-8096 Fix crash as per CER report for exceptions while opening file dialog box #15841

Merged
merged 3 commits into from
Feb 20, 2025

Conversation

zeusongit
Copy link
Contributor

Purpose

The PR adds exception handling around Dynamo file dialog box, the exception may have occurred when the user tried to open the file from a zipped location in Windows. The fix will prevent crash for any exception that occurs while opening file dialog box.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • Fix crash as per CER report for exceptions while opening file dialog box

Reviewers

@DynamoDS/dynamo

@zeusongit zeusongit added this to the 3.5 milestone Feb 19, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8096

@zeusongit
Copy link
Contributor Author

The failing test is a false positive, and I don't know when the smoke tests will be fixed/removed.

@zeusongit zeusongit merged commit 5ef260c into DynamoDS:master Feb 20, 2025
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants