[DYN 2316] consume library as npm package #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f5853c1.
…mo side) to librariejs (DynamoDS#225)" This reverts commit 5bd2f15.
QilongTang
reviewed
May 16, 2024
|
QilongTang
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
We keep js code implemented in Dynamo side (LibraryViewExtensionWebView2/web/library/library.html) as it is not relevant for other integrators. So these PRs are not needed anymore.
Add command line executed on
npm run productionto remove resources folder as it's not necessary for integrators. Therefore we'll just publish librarie.js bundle but keeping the resources path in the bundle so they can be overwrite on Dynamo side by Dynamo's own resources.REVIEW:
@QilongTang
@RobertGlobant20
FIY
@mjkkirschner